[U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

Anton Staaf
2011-08-29T23:05:32Z

On Mon, Aug 29, 2011 at 4:01 PM, Scott Wood <scottwood@freescale.com> wrote:
> On 08/29/2011 05:49 PM, Anton Staaf wrote:
>>>>> How do you make the declaration static?
>>>>
>>>> you can't with this version of the macro. ?Are there cases where you
>>>> need the buffer to be static?
>>>
>>> I think you'd want it to be static more often than not.
>>
>> If the buffer is allocated at file scope, then yes, we would want it
>> to be static. ?But not at function scope. ?It would no longer be
>> allocated on the stack in that case, and that was frowned upon
>> earlier.
>
> Ah, that's the issue. ?I was trying to declare it at file scope. :-P

Thank goodness, I was trying to figure out how that couldn't be a
valid GCC complaint. :)

Thanks,
Anton

> -Scott
>
>