[U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

Anton Staaf
2011-08-23T17:00:20Z

On Tue, Aug 23, 2011 at 2:19 AM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> Hi Anton,
>
> On Mon, 22 Aug 2011 11:57:57 -0700
> Anton Staaf <robotboy@google.com> wrote:
>
>> drivers/mmc/mmc.c: ext_csd in mmc_change_freq is allocated on the stac
>> drivers/mmc/mmc.c: scr and switch_status in sd_change_freq are
>> allocated on the stack.
>> drivers/mmc/mmc.c: ext_csd in mmc_startup is allocated on the stack.
>
> This allocations are already fixed:
>
> http://patchwork.ozlabs.org/patch/110300/
> http://patchwork.ozlabs.org/patch/109790/

Yup, should have said that you'd already taken care of some of these.
I'll send a patch now for another unaligned buffer in the mmc code
that isn't in your patch set.

Thanks,
Anton

> If any doubts/comments/ideas, please let me know :-)
>
>> But that's probably not right. ?I should probably send them now so we
>> can see a number of examples of the problem and get a better idea of
>> how to fix it.
>
> Discussion is always welcome.
>
> --
> Best regards,
>
> Lukasz Majewski
>
> Samsung Poland R&D Center
> Platform Group
>