[U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

Mike Frysinger
2011-08-23T17:30:13Z

On Tuesday, August 23, 2011 05:19:39 Lukasz Majewski wrote:
> On Mon, 22 Aug 2011 11:57:57 -0700 Anton Staaf wrote:
> > drivers/mmc/mmc.c: ext_csd in mmc_change_freq is allocated on the stac
> > drivers/mmc/mmc.c: scr and switch_status in sd_change_freq are
> > allocated on the stack.
> > drivers/mmc/mmc.c: ext_csd in mmc_startup is allocated on the stack.
>
> This allocations are already fixed:
>
> http://patchwork.ozlabs.org/patch/110300/
> http://patchwork.ozlabs.org/patch/109790/
>
> If any doubts/comments/ideas, please let me know :-)

hmm, i wish we had a memalign_alloca(). and all this copy & pasting of
get_dcache_line_size() makes me unhappy as we're encoding too-low-of-a-level
logic into funcs.

what about adding a new func like:
#define dma_buffer_alloca(size)

and it would take care of allocating a big enough aligned buffer on the stack.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110823/f58010ab/attachment.pgp