[U-Boot] [PATCH] mmc:dcache: Cache line size aligned internal MMC buffers

Mike Frysinger
2011-08-19T15:35:50Z

On Friday, August 19, 2011 11:28:18 Lukasz Majewski wrote:
> On Fri, 19 Aug 2011 09:57:10 -0400 Mike Frysinger wrote:
> > On Friday, August 19, 2011 05:25:13 Lukasz Majewski wrote:
> > > + cache_align_buf = memalign(get_dcache_line_size(),
> >
> > nowhere do i see get_dcache_line_size() defined
>
> Please look to the following post:
> http://patchwork.ozlabs.org/patch/110501/
>
> and another related with this issue:
> http://patchwork.ozlabs.org/patch/110300/

if you're posting patches with dependencies, you need to mention them
explicitly (below the "---" area), or send proper patch series ([PATCH N/M]).

ignoring that, this patch will break all arches except arm. that's bad
mmmkay. you probably need to move that weak def out of arm's cache.c and into
like lib/cache.c.

> > also, what is the code size increase with your patch ?
>
> Code size overhead (s5p_goni target):
> Without proposed changes: 167928 B (u-boot.bin)
> With changes: 168208 B (u-boot.bin)
>
> Delta: 280 B

np if it gives significant (more than system noise) speedups. any details on
that ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110819/baab5441/attachment.pgp