From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 8/9] DM9000: change some printf to use debug instead
Date: Thu, 25 Aug 2011 05:19:55 +0200 [thread overview]
Message-ID: <201108250519.55535.marek.vasut@gmail.com> (raw)
In-Reply-To: <683E266C-CDFB-4310-8145-1926C6FCCBD8@armadeus.org>
On Thursday, August 25, 2011 01:04:17 AM Eric Jarrige wrote:
> Dear Wolfgang,
>
> On 24 ao?t 2011, at 22:20, Wolfgang Denk wrote:
> > Dear Eric Jarrige,
> >
> > In message <2B613989-ADDB-43D6-A8C3-A30D5245262A@armadeus.org> you wrote:
> >>>> I'am just wondering: I see that DM9000_DBG is used all over dm9000
> >>>> code - do you know the reason why not just use debug()?
> >>
> >> dm9000 does not use debug() at all.
> >> That's the reason to fix the printf issues as a first priority by using
> >> the DM9000_DBG.
> >
> > NAK.
> >
> > If you touch that, then please do it right: us debug() instead, and
> > remove DM9000_DBG. Thanks.
>
> Do you mean both changes in one patch?
My wild guess would be to FIRST fix the DM9000_DBG and NEXT convert these
printf()s to debug()s.
Cheers
>
> Best regards,
> Eric
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
next prev parent reply other threads:[~2011-08-25 3:19 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 20:33 [U-Boot] [PATCH 0/9] Series short description Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 1/9] mx1: export imx_gpio_mode() function Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 2/9] mx1: add i2c registers Eric Jarrige
2011-08-11 8:52 ` Stefano Babic
2011-08-11 23:49 ` Eric Jarrige
2011-10-06 22:04 ` Wolfgang Denk
2011-08-10 20:33 ` [U-Boot] [PATCH 3/9] apf9328: Add Armadeus Project board APF9328 Eric Jarrige
2011-08-11 8:50 ` Stefano Babic
2011-08-11 23:41 ` Eric Jarrige
2011-08-12 6:49 ` Stefano Babic
2011-08-17 7:31 ` Igor Grinberg
2011-08-17 21:58 ` Eric Jarrige
2011-08-18 6:20 ` Igor Grinberg
2011-08-18 8:51 ` Stefano Babic
2011-08-10 20:33 ` [U-Boot] [PATCH 4/9] apf9328: add apf9328 board in Makefile Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 5/9] apf9328: add default board configuration file Eric Jarrige
2011-08-11 9:21 ` Stefano Babic
2011-08-15 20:25 ` Eric Jarrige
2011-08-23 9:46 ` Stefano Babic
2011-08-24 4:50 ` Eric Jarrige
2011-08-23 11:26 ` Wolfgang Denk
2011-08-24 4:56 ` Eric Jarrige
2011-08-24 5:49 ` Wolfgang Denk
2011-08-24 6:34 ` Wolfgang Denk
2011-08-24 23:01 ` Eric Jarrige
2011-08-24 22:26 ` Eric Jarrige
2011-08-24 22:56 ` Wolfgang Denk
2011-08-24 6:22 ` Stefano Babic
2011-08-24 23:08 ` Eric Jarrige
2011-10-06 22:03 ` Wolfgang Denk
2011-08-10 20:33 ` [U-Boot] [PATCH 6/9] mx1: improve PLL freq computation Eric Jarrige
2011-08-11 9:22 ` Stefano Babic
2011-08-12 0:03 ` Eric Jarrige
2011-08-12 0:28 ` Eric Jarrige
2011-08-12 6:51 ` Stefano Babic
2011-08-10 20:33 ` [U-Boot] [PATCH 7/9] mx1: change a printf in speed.c to use debug instead Eric Jarrige
2011-08-10 20:33 ` [U-Boot] [PATCH 8/9] DM9000: change some printf " Eric Jarrige
2011-08-11 7:26 ` Simon Schwarz
2011-08-11 8:01 ` Detlev Zundel
2011-08-11 10:51 ` Eric Jarrige
2011-08-24 20:20 ` Wolfgang Denk
2011-08-24 23:04 ` Eric Jarrige
2011-08-25 3:19 ` Marek Vasut [this message]
2011-08-25 5:49 ` Wolfgang Denk
2011-08-11 9:27 ` Stefano Babic
2011-08-10 20:33 ` [U-Boot] [PATCH 9/9] arm920t: Fix jump to the relocated board_init_r Eric Jarrige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108250519.55535.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox