public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100
Date: Mon, 29 Aug 2011 12:12:55 +0200	[thread overview]
Message-ID: <201108291212.56007.marek.vasut@gmail.com> (raw)
In-Reply-To: <1377932120.14674.1314596358776.JavaMail.root@ahm.einfochips.com>

On Monday, August 29, 2011 07:39:18 AM Ajay Bhargav wrote:
> ----- "Mike Frysinger" <vapier@gentoo.org> wrote:
> > On Monday, August 29, 2011 01:10:49 Ajay Bhargav wrote:
> > > ----- "Mike Frysinger" <vapier@gentoo.org> wrote:
> > > > On Friday, August 26, 2011 02:36:51 Ajay Bhargav wrote:
> > > > > +        darmdfec = malloc(sizeof(struct armdfec_device));
> > > > > +        if (!darmdfec)
> > > > > +                goto error;
> > > > 
> > > > if this first one fails, we jump to:
> > > > > +error:
> > > > > +        free(darmdfec->p_aligned_txbuf);
> > > > > +        free(darmdfec->p_rxbuf);
> > > > > +        free(darmdfec->p_rxdesc);
> > > > > +        free(darmdfec->htpr);
> > > > 
> > > > looks like 4 NULL pointer derefs.  so you'll need one specific
> > 
> > path
> > 
> > > > for the first malloc(), but the rest are fine.
> > > 
> > > so you mean like this...
> > > 
> > > if(!darmdfec)
> > > 
> > >         goto error;
> > > 
> > > ...
> > > 
> > > error1:
> > >         free(darmdfec->p_aligned_txbuf);
> > >         free(darmdfec->p_rxbuf);
> > >         free(darmdfec->p_rxdesc);
> > >         free(darmdfec->htpr);
> > > 
> > > error:
> > >         free(darmdfec);
> > >         return -1;
> > 
> > that's one way of fixing it
> > -mike
> 
> Any other better way?

I'd love to be enlightened on this topic too ...

> 
> --Ajay
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2011-08-29 10:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <706935361.14309.1314594441316.JavaMail.root@ahm.einfochips.com>
2011-08-29  5:10 ` [U-Boot] [PATCH v3 1/3] net: Adds Fast Ethernet Controller driver for Armada100 Ajay Bhargav
2011-08-29  5:30   ` Mike Frysinger
2011-08-29  5:39     ` Ajay Bhargav
2011-08-29 10:12       ` Marek Vasut [this message]
2011-08-29 19:39       ` Mike Frysinger
2011-08-30  5:15         ` Ajay Bhargav
     [not found] <274121072.14489.1314595589918.JavaMail.root@ahm.einfochips.com>
2011-08-29  5:26 ` Ajay Bhargav
2011-08-26  6:36 Ajay Bhargav
2011-08-26 15:32 ` Marek Vasut
2011-08-26 20:01 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108291212.56007.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox