From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] Pre-console buffer for ARM
Date: Mon, 29 Aug 2011 16:10:30 -0400 [thread overview]
Message-ID: <201108291610.31528.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ0dSF7NuXbQ2XXh45TM89LD2oMbV4k7zYCbuiaMkHJ5MQ@mail.gmail.com>
On Monday, August 29, 2011 15:42:23 Simon Glass wrote:
> On Mon, Aug 29, 2011 at 12:20 PM, Mike Frysinger wrote:
> > On Monday, August 29, 2011 13:21:57 Simon Glass wrote:
> >> + if (gd->con_buf_idx < CONFIG_SYS_TMP_CON_BUF_SZ)
> >> + buffer[gd->con_buf_idx++] = c;
> >
> > seems like a circular buffer would make more sense ... usually the part
> > of the log you want is the last chunk and not the first
>
> Yes I agree, although if you have more than 1KB of data it might be a bug.
give people a foot and they'll take 1MiB :p
it's fairly easy as well:
#define CIRC_BUF_IDX(idx) ((idx) & (CONFIG_SYS_TMP_CON_BUF_SZ-1))
buffer[CIRC_BUF_IDX(gd->conf_buf_idx++)] = c;
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110829/dfa93fa6/attachment.pgp
next prev parent reply other threads:[~2011-08-29 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 17:21 [U-Boot] [RFC PATCH] Pre-console buffer for ARM Simon Glass
2011-08-29 19:20 ` Mike Frysinger
2011-08-29 19:42 ` Simon Glass
2011-08-29 20:10 ` Mike Frysinger [this message]
2011-08-29 23:00 ` Graeme Russ
2011-08-30 1:32 ` Mike Frysinger
2011-08-30 1:49 ` Graeme Russ
2011-08-30 2:50 ` Mike Frysinger
2011-08-30 3:12 ` Graeme Russ
2011-08-30 5:17 ` Wolfgang Denk
2011-08-30 5:28 ` Graeme Russ
2011-08-30 9:29 ` Wolfgang Denk
2011-08-30 9:37 ` Graeme Russ
2011-08-29 22:49 ` Graeme Russ
2011-08-29 23:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108291610.31528.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox