public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] coldfire: Change timer_init return type from void to int
Date: Tue, 30 Aug 2011 11:10:59 -0400	[thread overview]
Message-ID: <201108301111.00896.vapier@gentoo.org> (raw)
In-Reply-To: <4E5CDEDA.40808@novasys-ingenierie.com>

On Tuesday, August 30, 2011 09:00:10 stany MARCEL wrote:
> --- a/arch/m68k/cpu/mcf547x_8x/slicetimer.c
> +++ b/arch/m68k/cpu/mcf547x_8x/slicetimer.c
> 
> -void timer_init(void)
> +int timer_init(void)

you should have gotten a build error as the prototype is in common.h.  so 
please add an include for common.h to this file.

> --- a/arch/m68k/lib/board.c
> +++ b/arch/m68k/lib/board.c
> 
> -extern	void timer_init(void);
> +extern int timer_init(void);

drop the extern and include common.h

> --- a/arch/m68k/lib/time.c
> +++ b/arch/m68k/lib/time.c
> 
> -void timer_init(void)
> +int timer_init(void)

include common.h in this file too
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110830/ee8de740/attachment.pgp 

  reply	other threads:[~2011-08-30 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-30 13:00 [U-Boot] [PATCH 1/5] coldfire: Change timer_init return type from void to int stany MARCEL
2011-08-30 15:10 ` Mike Frysinger [this message]
2011-09-02  7:52   ` Wolfgang Denk
2011-08-31 12:09 ` [U-Boot] [PATCH v2 " y at theia.denx.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201108301111.00896.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox