From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 31 Aug 2011 17:11:00 +0200 Subject: [U-Boot] [PATCH] arm: add 64-64 bit divider In-Reply-To: <201108311032.53475.vapier@gentoo.org> References: <1314787130-1043-1-git-send-email-clchiou@chromium.org> <201108311032.53475.vapier@gentoo.org> Message-ID: <201108311711.00249.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, August 31, 2011 04:32:52 PM Mike Frysinger wrote: > On Wednesday, August 31, 2011 06:38:50 Che-Liang Chiou wrote: > > This patch adds a 64-64 bit divider that supports ARMv4 and above. > > why ? if you're doing 64 bit divides, chances are you're doing something > fundamentally wrong. perhaps you should fix that instead. Oh come on Mike, what about too big NAND memories ? > > this is also why we have the do_div() helper macro. > > so until your changelog documents the actual *reason* for this patch: NAK The reason is likely it's faster. But I don't think it matters, that's why I commented on this already. If he's fixing something by this (like I mistakenly did some time ago), there's really something wrong. > -mike