From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: add 64-64 bit divider
Date: Wed, 31 Aug 2011 17:33:59 +0200 [thread overview]
Message-ID: <201108311733.59963.marek.vasut@gmail.com> (raw)
In-Reply-To: <201108311127.47392.vapier@gentoo.org>
On Wednesday, August 31, 2011 05:27:46 PM Mike Frysinger wrote:
> On Wednesday, August 31, 2011 11:11:00 Marek Vasut wrote:
> > On Wednesday, August 31, 2011 04:32:52 PM Mike Frysinger wrote:
> > > On Wednesday, August 31, 2011 06:38:50 Che-Liang Chiou wrote:
> > > > This patch adds a 64-64 bit divider that supports ARMv4 and above.
> > >
> > > why ? if you're doing 64 bit divides, chances are you're doing
> > > something fundamentally wrong. perhaps you should fix that instead.
> >
> > Oh come on Mike, what about too big NAND memories ?
>
> Linux hasnt had a problem supporting large NAND without a 64bit divide
> routine. why are we special ?
Because someone (?) has to fix the code that uses do_div() ;-)
>
> > > this is also why we have the do_div() helper macro.
> > >
> > > so until your changelog documents the actual *reason* for this patch:
> > > NAK
> >
> > The reason is likely it's faster.
>
> let's see actual #'s
True, will you make the measurements? ;-)
Still, I'd stick with the plain-C version, it doesn't matter I guess.
Cheers
> -mike
next prev parent reply other threads:[~2011-08-31 15:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 10:38 [U-Boot] [PATCH] arm: add 64-64 bit divider Che-Liang Chiou
2011-08-31 11:56 ` Marek Vasut
2011-08-31 14:32 ` Mike Frysinger
2011-08-31 15:11 ` Marek Vasut
2011-08-31 15:27 ` Mike Frysinger
2011-08-31 15:33 ` Marek Vasut [this message]
2011-08-31 16:05 ` Mike Frysinger
2011-08-31 16:30 ` Marek Vasut
2011-08-31 17:13 ` Mike Frysinger
2011-08-31 20:03 ` Wolfgang Denk
2011-09-01 10:09 ` Che-liang Chiou
2011-09-01 10:16 ` Marek Vasut
2011-09-01 10:30 ` Che-liang Chiou
2011-09-01 10:42 ` Marek Vasut
2011-09-01 12:06 ` Che-liang Chiou
2011-09-01 13:07 ` Wolfgang Denk
2011-09-02 3:12 ` Che-liang Chiou
2011-09-07 21:14 ` Wolfgang Denk
2011-09-20 10:45 ` Graeme Russ
2011-09-20 11:28 ` Wolfgang Denk
2011-09-20 11:40 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108311733.59963.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox