From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 0/4] Add basic clock and pinmux functions to the Tegra2
Date: Wed, 31 Aug 2011 18:42:29 -0400 [thread overview]
Message-ID: <201108311842.30981.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ2hKY4-fdyXemEeSSSq+ySTpOkZAfrywsb0PGpcY7WUtQ@mail.gmail.com>
On Wednesday, August 31, 2011 18:02:40 Simon Glass wrote:
> On Tue, Aug 30, 2011 at 7:47 PM, Mike Frysinger wrote:
> > On Tuesday, August 30, 2011 12:53:20 Albert ARIBAUD wrote:
> >> Patch series applied to u-boot-arm/master, with manual fix of three
> >> empty lines at EOF in patches 1 through 3.
> >>
> >> These empty lines and other whitespace errors can be found and fixed by
> >> the submitter before sending the patch to the list: just apply the
> >> patches to a local branch created at the intended commit where
> >
> >> application will happen, i.e.:
> > checkpatch.pl should catch it too i would think
> > -mike
>
> -checkpatch.pl v0.31 and v0.32 do not detect this for me
> -git format-patch does not seem to have an option to report it
> -git am notices it, but as Albert notes, the procedure is torturous
if you turn on colorization, `git diff` should highlight it as well as `git
log -p`. trailing new lines are a bit harder to catch than trailing spaces on
lines ...
i'm surprised checkpatch didnt catch these ... i guess someone needs to fix
that up :)
> For now I have added something to my script to find these errors in
> future, just by scanning the patches.
yeah, i wrote my own little check-patches helper as another thing ive seen but
checkpatch.pl doesnt catch is mixing of tabs and spaces.
grep -l '^[+].* \t' "$@"
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110831/0c20c46f/attachment.pgp
prev parent reply other threads:[~2011-08-31 22:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 16:23 [U-Boot] [PATCH v4 0/4] Add basic clock and pinmux functions to the Tegra2 Simon Glass
2011-08-30 16:23 ` [U-Boot] [PATCH v4 1/4] Tegra2: Add microsecond timer function Simon Glass
2011-08-30 16:23 ` [U-Boot] [PATCH v4 2/4] Tegra2: Add more clock support Simon Glass
2011-08-30 16:23 ` [U-Boot] [PATCH v4 3/4] Tegra2: Add additional pin multiplexing features Simon Glass
2011-08-30 16:23 ` [U-Boot] [PATCH v4 4/4] Tegra2: Use clock and pinmux functions to simplify code Simon Glass
2011-08-30 16:53 ` [U-Boot] [PATCH v4 0/4] Add basic clock and pinmux functions to the Tegra2 Albert ARIBAUD
2011-08-31 0:09 ` Simon Glass
2011-08-31 2:47 ` Mike Frysinger
2011-08-31 22:02 ` Simon Glass
2011-08-31 22:42 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108311842.30981.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox