From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 31 Aug 2011 22:01:59 +0200
Subject: [U-Boot] [PATCH v2] net: ll_temac: Add LL TEMAC driver to u-boot
In-Reply-To: <201108311526.27959.vapier@gentoo.org>
References: <1314705919-4237-1-git-send-email-monstr@monstr.eu>
	<201108311526.27959.vapier@gentoo.org>
Message-ID: <201108312201.59960.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, August 31, 2011 09:26:27 PM Mike Frysinger wrote:
> On Tuesday, August 30, 2011 08:05:18 Michal Simek wrote:
> > +	volatile struct temac_reg *regs = priv->regs;
> > +
> > +	regs->lsw = (phy_addr << 5) | reg_addr;
> > +	regs->ctl = MIIMAI | (emac << 10);
> 
> you should still be going through read/write i/o helper funcs rather than
> relying on the volatile markings

Oh, I didn't comment on the TEMAC. I'll have to go through it.

Cheers

> 
> the rest looks sane
> -mike