[U-Boot] [PATCH 05/15] common/main.c: Fix function readline

Mike Frysinger
2012-02-27T04:33:01Z

On Saturday 07 January 2012 03:51:16 Pali Roh?r wrote:
> On Friday 06 January 2012 15:15:29 Mike Frysinger wrote:
> > On Sunday 18 December 2011 16:34:01 Pali Roh?r wrote:
> > > * Ignore ANSI escape codes for moving cursor, which are generated by
> > >
> > > keyboard
> >
> > this probably should be behind an appropriate CONFIG knob. i don't think
> > this is relevant to serial users (which are the majority of boards).
>
> I think this is also relevant to serial console too. I tried serial console
> (over USB) with Nokia N900 on computer (ANSI terminal) and if I pressed
> cursor key (UP/DOWN/LEFT/RIGHT) it moved cursor. But in readline function
> buffer was stored ANSI sequence. So when I pressed ENTER, u-boot tried to
> execute that buffer and showed me error. But it showed error message
> something like unknown command <ansi_seq>. ansi_seq was recognized in ansi
> terminal on computer and it garbaged output. (for example if asn_seq was
> move up, error message continued on previous line...)
>
> This patch ignore ansi codes which can be generated by curosor keys, so
> there will not be that bad error messages...

do you have CONFIG_CMDLINE_EDITING enabled ? arrow keys work just fine when
that's enabled, and if it isn't, then i think it's expected behavior that
pressing the arrow keys would generate "junk" that u-boot wouldn't interpret.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120226/fd20c381/attachment.pgp>