[U-Boot] [PATCH 13/16] New config variable CONFIG_PREMONITOR

Pali Rohár
2011-12-18T20:14:42Z

On Sunday 18 December 2011 15:08:30 Mike Frysinger wrote:
> On Sunday 18 December 2011 14:37:12 Pali Roh?r wrote:
> > On Sunday 18 December 2011 14:05:17 Mike Frysinger wrote:
> > > On Saturday 17 December 2011 12:03:15 Pali Roh?r wrote:
> > > > --- a/common/env_common.c
> > > > +++ b/common/env_common.c
> > > >
> > > > +#ifdef CONFIG_PREMONITOR
> > > > + "premonitor=" CONFIG_PREMONITOR "\0"
> > > > +#endif
> > > >
> > > > --- a/common/main.c
> > > > +++ b/common/main.c
> > > >
> > > > +#ifdef CONFIG_PREMONITOR
> > > > + if ((s = getenv ("premonitor")) != NULL) {
> > >
> > > i don't these should be the same define. one is to control the
> > > default
> > > env var value only. i would just drop the check in main.c.
> >
> > So do you think that I should delete changes in env_common.c and add to
> > main.c only this code?
>
> i mean keep the code in env_common.c, and delete the "#ifdef
> CONFIG_PREMONITOR" line from main.c
> -mike

Ok.

--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111218/177e84bb/attachment.pgp>