public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file
Date: Mon, 5 Sep 2011 15:05:16 +0200	[thread overview]
Message-ID: <201109051505.17165.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAOMZO5Aszk=Uxyxbns8O6f3w4oLcLOQHyY5Y2Vf9ns2AoOisKA@mail.gmail.com>

On Monday, September 05, 2011 01:37:17 PM Fabio Estevam wrote:
> On Mon, Sep 5, 2011 at 7:43 AM, Stefano Babic <sbabic@denx.de> wrote:
> ...
> 
> > What about to move the prototype ? For MX5/MX35 there is a sys_proto.h
> > (as it is done for other SOCs), in this case, well, it seems too much to
> > add a file for a single line. However, we could move it in clock.h and
> > creating a sys_proto.h if the number of exported functions will increase.
> 
> Ok, I can create a sys_proto.h for MX25 and put the following extern?s
> there:
> 
> extern void mx25_fec_init_pins(void);
> extern void imx_get_mac_from_fuse(unsigned char *mac);
> extern void mx25_uart1_init_pins(void);

Ok, this might be a stupid one, but ...

why use externs in header files ?

> 
> Regards,
> 
> Fabio Estevam
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2011-09-05 13:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-02 14:02 [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Fabio Estevam
2011-09-02 14:02 ` [U-Boot] [PATCH v3 2/2] MX25: Add initial support for MX25PDK Fabio Estevam
2011-09-05 10:43 ` [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Stefano Babic
2011-09-05 11:37   ` Fabio Estevam
2011-09-05 13:05     ` Marek Vasut [this message]
2011-09-05 13:15       ` Fabio Estevam
2011-09-05 15:05         ` Marek Vasut
2011-09-05 15:38           ` Fabio Estevam
2011-09-05 15:40             ` Marek Vasut
2011-09-05 15:48               ` Fabio Estevam
2011-09-05 16:02                 ` Wolfgang Denk
2011-09-05 16:12                   ` Marek Vasut
2011-09-05 16:49                 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109051505.17165.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox