From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 5 Sep 2011 15:05:16 +0200
Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern
	in C file
In-Reply-To: <CAOMZO5Aszk=Uxyxbns8O6f3w4oLcLOQHyY5Y2Vf9ns2AoOisKA@mail.gmail.com>
References: <1314972139-20068-1-git-send-email-fabio.estevam@freescale.com>
	<4E64A7C6.9000208@denx.de>
	<CAOMZO5Aszk=Uxyxbns8O6f3w4oLcLOQHyY5Y2Vf9ns2AoOisKA@mail.gmail.com>
Message-ID: <201109051505.17165.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, September 05, 2011 01:37:17 PM Fabio Estevam wrote:
> On Mon, Sep 5, 2011 at 7:43 AM, Stefano Babic <sbabic@denx.de> wrote:
> ...
> 
> > What about to move the prototype ? For MX5/MX35 there is a sys_proto.h
> > (as it is done for other SOCs), in this case, well, it seems too much to
> > add a file for a single line. However, we could move it in clock.h and
> > creating a sys_proto.h if the number of exported functions will increase.
> 
> Ok, I can create a sys_proto.h for MX25 and put the following extern?s
> there:
> 
> extern void mx25_fec_init_pins(void);
> extern void imx_get_mac_from_fuse(unsigned char *mac);
> extern void mx25_uart1_init_pins(void);

Ok, this might be a stupid one, but ...

why use externs in header files ?

> 
> Regards,
> 
> Fabio Estevam
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot