From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 5 Sep 2011 17:04:45 +0200
Subject: [U-Boot] [PATCH] UBIFS: Change ubifsload to set the filesize
	variable
In-Reply-To: <20110905142728.9F0E0140ABDF@gemini.denx.de>
References: <1315220629-9192-1-git-send-email-Bastian.Ruppert@Sewerin.de>
	<201109051512.48148.marek.vasut@gmail.com>
	<20110905142728.9F0E0140ABDF@gemini.denx.de>
Message-ID: <201109051704.45430.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, September 05, 2011 04:27:28 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
> 
> In message <201109051512.48148.marek.vasut@gmail.com> you wrote:
> > > +	setenv("filesize", buf);
> > 
> > maybe you want to check set_local_var() too ?
> 
> Yes, we should clean up all these auto-generated environment variables
> one day.  But what you propose here is not a good approach:
> 
> (1) not all boards use the hush shell, and set_local_var() is only
>     available there.
> (2) if you make such a change, then you must make it everywhere, and
>     you must make sure not to break existent use of these things.
> 
> Both is definitely out of the scope of this patch.

You're definitelly right on this thing.

> 
> Best regards,
> 
> Wolfgang Denk