From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file
Date: Mon, 5 Sep 2011 17:40:57 +0200 [thread overview]
Message-ID: <201109051740.57608.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAOMZO5CS6szn-EzvLpqB5U08bF3pnLRyAD0O+0wGK-4uGcJAZA@mail.gmail.com>
On Monday, September 05, 2011 05:38:26 PM Fabio Estevam wrote:
> On Mon, Sep 5, 2011 at 12:05 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > On Monday, September 05, 2011 03:15:44 PM Fabio Estevam wrote:
> >> On Mon, Sep 5, 2011 at 10:05 AM, Marek Vasut <marek.vasut@gmail.com>
> >> wrote: ...
> >>
> >> >> extern void mx25_fec_init_pins(void);
> >> >> extern void imx_get_mac_from_fuse(unsigned char *mac);
> >> >> extern void mx25_uart1_init_pins(void);
> >> >
> >> > Ok, this might be a stupid one, but ...
> >> >
> >> > why use externs in header files ?
> >>
> >> This will make checkpatch happy :-)
> >
> > I'm not quite sure I understand ... ?
>
> ./scripts/checkpatch.pl -F u-boot/board/karo/tx25/tx25.c
> ....
> WARNING: externs should be avoided in .c files
> #144: FILE: home/fabio/denx/u-boot/board/karo/tx25/tx25.c:144:
> + extern void mx25_uart1_init_pins(void);
But you're using extern in _header_ (.h) file ... so ... why ?
next prev parent reply other threads:[~2011-09-05 15:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 14:02 [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Fabio Estevam
2011-09-02 14:02 ` [U-Boot] [PATCH v3 2/2] MX25: Add initial support for MX25PDK Fabio Estevam
2011-09-05 10:43 ` [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Stefano Babic
2011-09-05 11:37 ` Fabio Estevam
2011-09-05 13:05 ` Marek Vasut
2011-09-05 13:15 ` Fabio Estevam
2011-09-05 15:05 ` Marek Vasut
2011-09-05 15:38 ` Fabio Estevam
2011-09-05 15:40 ` Marek Vasut [this message]
2011-09-05 15:48 ` Fabio Estevam
2011-09-05 16:02 ` Wolfgang Denk
2011-09-05 16:12 ` Marek Vasut
2011-09-05 16:49 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109051740.57608.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox