From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 5 Sep 2011 17:40:57 +0200
Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern
	in C file
In-Reply-To: <CAOMZO5CS6szn-EzvLpqB5U08bF3pnLRyAD0O+0wGK-4uGcJAZA@mail.gmail.com>
References: <1314972139-20068-1-git-send-email-fabio.estevam@freescale.com>
	<201109051705.09020.marek.vasut@gmail.com>
	<CAOMZO5CS6szn-EzvLpqB5U08bF3pnLRyAD0O+0wGK-4uGcJAZA@mail.gmail.com>
Message-ID: <201109051740.57608.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, September 05, 2011 05:38:26 PM Fabio Estevam wrote:
> On Mon, Sep 5, 2011 at 12:05 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > On Monday, September 05, 2011 03:15:44 PM Fabio Estevam wrote:
> >> On Mon, Sep 5, 2011 at 10:05 AM, Marek Vasut <marek.vasut@gmail.com>
> >> wrote: ...
> >> 
> >> >> extern void mx25_fec_init_pins(void);
> >> >> extern void imx_get_mac_from_fuse(unsigned char *mac);
> >> >> extern void mx25_uart1_init_pins(void);
> >> > 
> >> > Ok, this might be a stupid one, but ...
> >> > 
> >> > why use externs in header files ?
> >> 
> >> This will make checkpatch happy :-)
> > 
> > I'm not quite sure I understand ... ?
> 
> ./scripts/checkpatch.pl -F u-boot/board/karo/tx25/tx25.c
> ....
> WARNING: externs should be avoided in .c files
> #144: FILE: home/fabio/denx/u-boot/board/karo/tx25/tx25.c:144:
> +	extern void mx25_uart1_init_pins(void);

But you're using extern in _header_ (.h) file ... so ... why ?