From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file
Date: Mon, 5 Sep 2011 18:12:35 +0200 [thread overview]
Message-ID: <201109051812.35515.marek.vasut@gmail.com> (raw)
In-Reply-To: <20110905160221.6404B158D108@gemini.denx.de>
On Monday, September 05, 2011 06:02:21 PM Wolfgang Denk wrote:
> Dear Fabio Estevam,
>
> In message
<CAOMZO5A1v5jUkXTF9nKnZh8VNewzkoMB1tMmE9cRJCJDp+y2ug@mail.gmail.com> you wrote:
> > > But you're using extern in _header_ (.h) file ... so ... why ?
> >
> > My patch removes the extern from the C file and put it on a header
> > file with other extern's.
>
> What Marek probably wants to tell yet (in a bit a complicated way) is
> that you should omit the "extern" in the prototype declaration. Just
> remove all "extern" from the header file.
No, I was asking if there's some special reason for this or it's plain wrong. I
see the later's the case.
Thanks, cheers!
>
> Best regards,
>
> Wolfgang Denk
next prev parent reply other threads:[~2011-09-05 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 14:02 [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Fabio Estevam
2011-09-02 14:02 ` [U-Boot] [PATCH v3 2/2] MX25: Add initial support for MX25PDK Fabio Estevam
2011-09-05 10:43 ` [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern in C file Stefano Babic
2011-09-05 11:37 ` Fabio Estevam
2011-09-05 13:05 ` Marek Vasut
2011-09-05 13:15 ` Fabio Estevam
2011-09-05 15:05 ` Marek Vasut
2011-09-05 15:38 ` Fabio Estevam
2011-09-05 15:40 ` Marek Vasut
2011-09-05 15:48 ` Fabio Estevam
2011-09-05 16:02 ` Wolfgang Denk
2011-09-05 16:12 ` Marek Vasut [this message]
2011-09-05 16:49 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109051812.35515.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox