From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 5 Sep 2011 18:12:35 +0200
Subject: [U-Boot] [PATCH v3 1/2] MX25: tx25: Avoid the usage of extern
	in C file
In-Reply-To: <20110905160221.6404B158D108@gemini.denx.de>
References: <1314972139-20068-1-git-send-email-fabio.estevam@freescale.com>
	<CAOMZO5A1v5jUkXTF9nKnZh8VNewzkoMB1tMmE9cRJCJDp+y2ug@mail.gmail.com>
	<20110905160221.6404B158D108@gemini.denx.de>
Message-ID: <201109051812.35515.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, September 05, 2011 06:02:21 PM Wolfgang Denk wrote:
> Dear Fabio Estevam,
> 
> In message 
<CAOMZO5A1v5jUkXTF9nKnZh8VNewzkoMB1tMmE9cRJCJDp+y2ug@mail.gmail.com> you wrote:
> > > But you're using extern in _header_ (.h) file ... so ... why ?
> > 
> > My patch removes the extern from the C file and put it on a header
> > file with other extern's.
> 
> What Marek probably wants to tell yet (in a bit a complicated way) is
> that you should omit the "extern" in the prototype declaration. Just
> remove all "extern" from the header file.

No, I was asking if there's some special reason for this or it's plain wrong. I 
see the later's the case.

Thanks, cheers!
> 
> Best regards,
> 
> Wolfgang Denk