[U-Boot] Bogus "Warning: failed to set MAC address" on Gumstix Overo

[Wolfgang Denk <wd@denx.de>]

Dear Philip Balister,

In message <4E68C67F.2080002@opensdr.com> you wrote:
> When booting master on a Gumstix Overo based system, I get the following 
> messages during ethernet initialization:
> 
> Net:   smc911x-0
> Warning: failed to set MAC address
> 
> (Note that patch [1] is needed to move the Warning to a new line, 
> otherwise it is after the previous line with no space)
> 
> In this system, the ethernet chip is loading the MAC address from an 
> attached eeprom, so the warning is inaccurate. I've looked at the code 

The warning gets printed when eth_write_hwaddr() fails.

What makes you claim that this is not correct?  There _is_ a problem
when eth_write_hwaddr() returns an error code.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Unser Kopf ist rund, damit das Denken die Richtung wechseln kann.
                                                   -- Francis Picabia