From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra2: Enable data cache
Date: Thu, 8 Sep 2011 20:25:46 -0400 [thread overview]
Message-ID: <201109082025.47884.vapier@gentoo.org> (raw)
In-Reply-To: <1315520416-6407-1-git-send-email-sjg@chromium.org>
On Thursday, September 08, 2011 18:20:16 Simon Glass wrote:
> --- a/board/nvidia/common/board.c
> +++ b/board/nvidia/common/board.c
> @@ -307,3 +307,11 @@ int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> return 0;
> }
> #endif
> +
> +#ifndef CONFIG_SYS_DCACHE_OFF
> +void enable_caches(void)
> +{
> + /* Enable D-cache. I-cache is already enabled in start.S */
> + dcache_enable();
> +}
> +#endif
not specific to your patch, but this seems kind of dumb to copy & paste the
same thing between all the arm sub arches/boards. why cant the default
enable_caches() look like this for arm:
void enable_caches(void)
{
#ifndef CONFIG_SYS_DCACHE_OFF
dcache_enable();
#endif
#ifndef CONFIG_SYS_ICACHE_OFF
icache_enable();
#endif
}
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110908/1d7cee40/attachment.pgp
next prev parent reply other threads:[~2011-09-09 0:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 22:20 [U-Boot] [PATCH] tegra2: Enable data cache Simon Glass
2011-09-09 0:25 ` Mike Frysinger [this message]
2011-09-09 0:30 ` Marek Vasut
2011-09-09 3:10 ` Simon Glass
2011-09-14 13:10 ` Aneesh V
2011-09-14 15:13 ` Simon Glass
2011-09-15 3:03 ` Mike Frysinger
2011-09-15 16:21 ` Albert ARIBAUD
2011-09-15 16:31 ` Mike Frysinger
2011-09-15 17:30 ` Albert ARIBAUD
2011-09-15 17:41 ` Mike Frysinger
2011-09-21 21:27 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109082025.47884.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox