From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tegra2: Enable data cache
Date: Fri, 9 Sep 2011 02:30:54 +0200 [thread overview]
Message-ID: <201109090230.55026.marek.vasut@gmail.com> (raw)
In-Reply-To: <201109082025.47884.vapier@gentoo.org>
On Friday, September 09, 2011 02:25:46 AM Mike Frysinger wrote:
> On Thursday, September 08, 2011 18:20:16 Simon Glass wrote:
> > --- a/board/nvidia/common/board.c
> > +++ b/board/nvidia/common/board.c
> > @@ -307,3 +307,11 @@ int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> >
> > return 0;
> >
> > }
> > #endif
> >
> > +
> > +#ifndef CONFIG_SYS_DCACHE_OFF
> > +void enable_caches(void)
> > +{
> > + /* Enable D-cache. I-cache is already enabled in start.S */
> > + dcache_enable();
> > +}
> > +#endif
>
> not specific to your patch, but this seems kind of dumb to copy & paste the
> same thing between all the arm sub arches/boards. why cant the default
> enable_caches() look like this for arm:
> void enable_caches(void)
> {
> #ifndef CONFIG_SYS_DCACHE_OFF
> dcache_enable();
> #endif
> #ifndef CONFIG_SYS_ICACHE_OFF
> icache_enable();
> #endif
> }
> -mike
Makes sense ... and also, we won't eventually need this "enable_caches()" at all
in cpu-directories. It can then be moved to lib/.
next prev parent reply other threads:[~2011-09-09 0:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 22:20 [U-Boot] [PATCH] tegra2: Enable data cache Simon Glass
2011-09-09 0:25 ` Mike Frysinger
2011-09-09 0:30 ` Marek Vasut [this message]
2011-09-09 3:10 ` Simon Glass
2011-09-14 13:10 ` Aneesh V
2011-09-14 15:13 ` Simon Glass
2011-09-15 3:03 ` Mike Frysinger
2011-09-15 16:21 ` Albert ARIBAUD
2011-09-15 16:31 ` Mike Frysinger
2011-09-15 17:30 ` Albert ARIBAUD
2011-09-15 17:41 ` Mike Frysinger
2011-09-21 21:27 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109090230.55026.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox