From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX
Date: Fri, 9 Sep 2011 09:05:37 +0200 [thread overview]
Message-ID: <201109090905.37819.sr@denx.de> (raw)
In-Reply-To: <20110909065127.0804C140875B@gemini.denx.de>
Hi Bernhard,
On Friday 09 September 2011 08:51:26 Wolfgang Denk wrote:
> > Hello,
> >
> > I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member,
> > but should have two. So I propose this very simple patch.
> >
> > Best regards,
> > Bernhard Weirich
> >
> > Signed-off-by: Bernhard Weirich <bernhard.weirich@riedel.net>
> > --- u-boot-v2010.12-rc3-orig/arch/powerpc/include/asm/u-boot.h
2010-12-20
> > 10:58:41.000000000 +0100 +++
> > u-boot-v2010.12-rc3/arch/powerpc/include/asm/u-boot.h 2011-09-08
> > 18:25:57.136700984 +0200 @@ -132,7 +132,7 @@
> >
> > defined(CONFIG_460EX) || defined(CONFIG_460GT)
> >
> > int bi_phynum[4]; /* Determines phy mapping */
> > int bi_phymode[4]; /* Determines phy mode */
> >
> > -#elif defined(CONFIG_405EP) || defined(CONFIG_440)
> > +#elif defined(CONFIG_405EP) || defined(CONFIG_440) ||
> > defined(CONFIG_405EX)
Thanks for catching this.
> Please keep list sorted, and move the "Best regards," part out of the
> commit message.
Yes. And please add a "Signed-off-by: .." line instead. I suggest you take a
look at other patches submitted to the list to see how a "proper" commit text
is composed.
Thanks.
Best regards,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2011-09-09 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 16:27 [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX Weirich, Bernhard
2011-09-09 6:51 ` Wolfgang Denk
2011-09-09 7:05 ` Stefan Roese [this message]
2011-09-19 11:58 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109090905.37819.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox