From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 9 Sep 2011 09:05:37 +0200
Subject: [U-Boot] [PATCH] Fix incorrect array size of phy settings for
	405EX
In-Reply-To: <20110909065127.0804C140875B@gemini.denx.de>
References: <6680AE1BD102B9419251E785D19F5D039FA037F6@ExchN1.riedel.net>
	<20110909065127.0804C140875B@gemini.denx.de>
Message-ID: <201109090905.37819.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Bernhard,

On Friday 09 September 2011 08:51:26 Wolfgang Denk wrote:
> > Hello,
> > 
> > I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member,
> > but should have two. So I propose this very simple patch.
> > 
> > Best regards,
> > Bernhard Weirich
> > 
> > Signed-off-by: Bernhard Weirich <bernhard.weirich@riedel.net>
> > --- u-boot-v2010.12-rc3-orig/arch/powerpc/include/asm/u-boot.h	
2010-12-20
> > 10:58:41.000000000 +0100 +++
> > u-boot-v2010.12-rc3/arch/powerpc/include/asm/u-boot.h	2011-09-08
> > 18:25:57.136700984 +0200 @@ -132,7 +132,7 @@
> > 
> >      defined(CONFIG_460EX) || defined(CONFIG_460GT)
> >  	
> >  	int		bi_phynum[4];           /* Determines phy mapping */
> >  	int		bi_phymode[4];          /* Determines phy mode */
> > 
> > -#elif defined(CONFIG_405EP) || defined(CONFIG_440)
> > +#elif defined(CONFIG_405EP) || defined(CONFIG_440) ||
> > defined(CONFIG_405EX)

Thanks for catching this.
 
> Please keep list sorted, and move the "Best regards," part out of the
> commit message.

Yes. And please add a "Signed-off-by: .." line instead. I suggest you take a 
look at other patches submitted to the list to see how a "proper" commit text 
is composed.

Thanks.
 
Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de