* [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX
@ 2011-09-08 16:27 Weirich, Bernhard
2011-09-09 6:51 ` Wolfgang Denk
2011-09-19 11:58 ` Stefan Roese
0 siblings, 2 replies; 4+ messages in thread
From: Weirich, Bernhard @ 2011-09-08 16:27 UTC (permalink / raw)
To: u-boot
Hello,
I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member, but should have two.
So I propose this very simple patch.
Best regards,
Bernhard Weirich
Signed-off-by: Bernhard Weirich <bernhard.weirich@riedel.net>
--- u-boot-v2010.12-rc3-orig/arch/powerpc/include/asm/u-boot.h 2010-12-20 10:58:41.000000000 +0100
+++ u-boot-v2010.12-rc3/arch/powerpc/include/asm/u-boot.h 2011-09-08 18:25:57.136700984 +0200
@@ -132,7 +132,7 @@
defined(CONFIG_460EX) || defined(CONFIG_460GT)
int bi_phynum[4]; /* Determines phy mapping */
int bi_phymode[4]; /* Determines phy mode */
-#elif defined(CONFIG_405EP) || defined(CONFIG_440)
+#elif defined(CONFIG_405EP) || defined(CONFIG_440) || defined(CONFIG_405EX)
int bi_phynum[2]; /* Determines phy mapping */
int bi_phymode[2]; /* Determines phy mode */
#else
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX
2011-09-08 16:27 [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX Weirich, Bernhard
@ 2011-09-09 6:51 ` Wolfgang Denk
2011-09-09 7:05 ` Stefan Roese
2011-09-19 11:58 ` Stefan Roese
1 sibling, 1 reply; 4+ messages in thread
From: Wolfgang Denk @ 2011-09-09 6:51 UTC (permalink / raw)
To: u-boot
Dear "Weirich, Bernhard",
In message <6680AE1BD102B9419251E785D19F5D039FA037F6@ExchN1.riedel.net> you wrote:
> Hello,
>
> I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member, but should have two.
> So I propose this very simple patch.
>
> Best regards,
> Bernhard Weirich
>
> Signed-off-by: Bernhard Weirich <bernhard.weirich@riedel.net>
> --- u-boot-v2010.12-rc3-orig/arch/powerpc/include/asm/u-boot.h 2010-12-20 10:58:41.000000000 +0100
> +++ u-boot-v2010.12-rc3/arch/powerpc/include/asm/u-boot.h 2011-09-08 18:25:57.136700984 +0200
> @@ -132,7 +132,7 @@
> defined(CONFIG_460EX) || defined(CONFIG_460GT)
> int bi_phynum[4]; /* Determines phy mapping */
> int bi_phymode[4]; /* Determines phy mode */
> -#elif defined(CONFIG_405EP) || defined(CONFIG_440)
> +#elif defined(CONFIG_405EP) || defined(CONFIG_440) || defined(CONFIG_405EX)
Please keep list sorted, and move the "Best regards," part out of the
commit message.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If you want strict real-time behavior, run in the real time schedu-
ling class. But there are no seatbelts or airbags; main(){for(;;);}
can hard hang your system. -- Bart Smaalders
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX
2011-09-09 6:51 ` Wolfgang Denk
@ 2011-09-09 7:05 ` Stefan Roese
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2011-09-09 7:05 UTC (permalink / raw)
To: u-boot
Hi Bernhard,
On Friday 09 September 2011 08:51:26 Wolfgang Denk wrote:
> > Hello,
> >
> > I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member,
> > but should have two. So I propose this very simple patch.
> >
> > Best regards,
> > Bernhard Weirich
> >
> > Signed-off-by: Bernhard Weirich <bernhard.weirich@riedel.net>
> > --- u-boot-v2010.12-rc3-orig/arch/powerpc/include/asm/u-boot.h
2010-12-20
> > 10:58:41.000000000 +0100 +++
> > u-boot-v2010.12-rc3/arch/powerpc/include/asm/u-boot.h 2011-09-08
> > 18:25:57.136700984 +0200 @@ -132,7 +132,7 @@
> >
> > defined(CONFIG_460EX) || defined(CONFIG_460GT)
> >
> > int bi_phynum[4]; /* Determines phy mapping */
> > int bi_phymode[4]; /* Determines phy mode */
> >
> > -#elif defined(CONFIG_405EP) || defined(CONFIG_440)
> > +#elif defined(CONFIG_405EP) || defined(CONFIG_440) ||
> > defined(CONFIG_405EX)
Thanks for catching this.
> Please keep list sorted, and move the "Best regards," part out of the
> commit message.
Yes. And please add a "Signed-off-by: .." line instead. I suggest you take a
look at other patches submitted to the list to see how a "proper" commit text
is composed.
Thanks.
Best regards,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX
2011-09-08 16:27 [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX Weirich, Bernhard
2011-09-09 6:51 ` Wolfgang Denk
@ 2011-09-19 11:58 ` Stefan Roese
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Roese @ 2011-09-19 11:58 UTC (permalink / raw)
To: u-boot
Hi Bernhard,
On Thursday 08 September 2011 18:27:38 Weirich, Bernhard wrote:
> Hello,
>
> I just noticed that on 405EX the bd_t->bi_phy* arrays have just 1 member,
> but should have two. So I propose this very simple patch.
>
> Best regards,
> Bernhard Weirich
>
> Signed-off-by: Bernhard Weirich <bernhard.weirich@riedel.net>
Applied, after manually fixing all the formal issues with this patch
(commit message tweaked, line too long). Additionally the requested
change from Wolfgang (list sorted) has been made.
Thanks.
Best regards,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-09-19 11:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-08 16:27 [U-Boot] [PATCH] Fix incorrect array size of phy settings for 405EX Weirich, Bernhard
2011-09-09 6:51 ` Wolfgang Denk
2011-09-09 7:05 ` Stefan Roese
2011-09-19 11:58 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox