From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Fri, 9 Sep 2011 11:13:32 +0200
Subject: [U-Boot] [PATCH 05/11] FEC: Allow selection of MII mode via
	CONFIG_FEC_XCV_TYPE
In-Reply-To: <201109082048.47609.vapier@gentoo.org>
References: <1315514242-18998-1-git-send-email-marek.vasut@gmail.com>
	<1315514242-18998-6-git-send-email-marek.vasut@gmail.com>
	<201109082048.47609.vapier@gentoo.org>
Message-ID: <201109091113.32700.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, September 09, 2011 02:48:46 AM Mike Frysinger wrote:
> On Thursday, September 08, 2011 16:37:16 Marek Vasut wrote:
> > --- a/drivers/net/fec_mxc.c
> > +++ b/drivers/net/fec_mxc.c
> > @@ -38,6 +38,10 @@ DECLARE_GLOBAL_DATA_PTR;
> > 
> >  #error "CONFIG_MII has to be defined!"
> >  #endif
> > 
> > +#ifndef	CONFIG_FEC_XCV_TYPE
> > +#define	CONFIG_FEC_XCV_TYPE	MII100
> > +#endif
> > +
> > 
> >  #undef DEBUG
> >  
> >  struct nbuf {
> > 
> > @@ -711,7 +715,7 @@ static int fec_probe(bd_t *bd)
> > 
> >  	fec->eth = (struct ethernet_regs *)IMX_FEC_BASE;
> >  	fec->bd = bd;
> > 
> > -	fec->xcv_type = MII100;
> > +	fec->xcv_type = CONFIG_FEC_XCV_TYPE;
> 
> shouldnt this be a parameter to fec_probe() ?
> -mike

We plan to add a driver model eventually. Until then, let's not polute this more 
than necessary.