From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 9 Sep 2011 13:26:18 +0200
Subject: [U-Boot] [PATCH 12/31] iMX28: Add I2C bus driver
In-Reply-To: <201109091318.40259.marek.vasut@gmail.com>
References: <1315514579-19215-1-git-send-email-marek.vasut@gmail.com>
	<4E69A7E9.1090302@denx.de>
	<201109091318.40259.marek.vasut@gmail.com>
Message-ID: <201109091326.18558.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On Friday 09 September 2011 13:18:40 Marek Vasut wrote:
> > > +		if (tmp & (
> > > +			I2C_CTRL1_EARLY_TERM_IRQ | I2C_CTRL1_MASTER_LOSS_IRQ |
> > > +			I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ
> > > +		)) {
> > 
> > Checkpatch don;t beats here, but I think, two line are not necessary
> > 
> > here, just do a:
> > 			I2C_CTRL1_SLAVE_STOP_IRQ | I2C_CTRL1_SLAVE_IRQ)) {
> > 
> > Beside of that, patch looks good to me, so:
> I think it's more readable as it is ... what do the others think ?

I'm definitely with Heiko here! ;)

Ciao,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de