From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Fri, 9 Sep 2011 14:50:34 +0200
Subject: [U-Boot] [PATCH 18/31] iMX28: Add SPI driver
In-Reply-To: <4E6A07BD.8010103@denx.de>
References: <1315514579-19215-1-git-send-email-marek.vasut@gmail.com>
	<201109091350.16806.marek.vasut@gmail.com>
	<4E6A07BD.8010103@denx.de>
Message-ID: <201109091450.34972.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, September 09, 2011 02:34:05 PM Stefano Babic wrote:
> On 09/09/2011 01:50 PM, Marek Vasut wrote:
> >> Only the CS supplied in the SOC are supported, it is not possible to use
> >> a GPIO. Please add a comment to explain that.
> 
> If you see other SPI drivers (mxc_spi.c, or blackfin, and other, too)
> the CS is or can be implemented with a gpio. Some architecture have a
> board specific spi_cs_activate.
> 
> In your driver, only the CS of the SPI controller are supported. My only
> remark is if we can add a comment to explain this.
> 

Done,cheers

> Best regards,
> Stefano Babic