From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sat, 10 Sep 2011 00:04:10 +0200
Subject: [U-Boot] [PATCH v3] Add assert() for debug assertions
In-Reply-To: <1309376974-12943-1-git-send-email-sjg@chromium.org>
References: <1309376974-12943-1-git-send-email-sjg@chromium.org>
Message-ID: <20110909220410.4935D140876B@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Simon Glass,

In message <1309376974-12943-1-git-send-email-sjg@chromium.org> you wrote:
> assert() is like BUG_ON() but compiles to nothing unless DEBUG is defined.
> This is useful when a condition is an error but a board reset is unlikely
> to fix it, so it is better to soldier on in hope. Assertion failures should
> be caught during development/test.
> 
> It turns out that assert() is defined separately in a few places in U-Boot
> with various meanings. This patch cleans up some of these.
> 
> Build errors exposed by this change (and defining DEBUG) are also fixed in
> this patch.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Changed macros so that all code is compiled even if DEBUG is disabled
> 
> Changes in v3:
> - Use panic() instead of printf()
> - Use separate __assert_fail() function to reduce memory footprint
> - Changed output format to match assert(3)
> 
>  common/dlmalloc.c |    7 -------
>  include/common.h  |   21 +++++++++++++++++++++
>  include/malloc.h  |    8 --------
>  lib/qsort.c       |    5 -----
>  lib/vsprintf.c    |    8 ++++++++
>  5 files changed, 29 insertions(+), 20 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How can you tell when sour cream goes bad?