From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sughosh Ganu Date: Mon, 12 Sep 2011 16:35:27 +0530 Subject: [U-Boot] [PATCH] ARM: hawkboard: fix compilation of nand_spl In-Reply-To: <4E69D68E.4090504@denx.de> References: <1315552622-27566-1-git-send-email-sbabic@denx.de> <20110909073638.2275F1408769@gemini.denx.de> <4E69D68E.4090504@denx.de> Message-ID: <20110912110527.GA19853@Hardy> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de hi Stefano, On Fri Sep 09, 2011 at 11:04:14AM +0200, Stefano Babic wrote: > On 09/09/2011 09:36 AM, Wolfgang Denk wrote: > > > >> +# from comon directory > >> +$(obj)memsize.c: > >> + @rm -f $@ > >> + ln -s $(TOPDIR)/common/memsize.c $@ > > > > Can we not rather compile the file in the common directory instead? > > This is only for nand_spl, not for u-boot. The nand_spl/board/Makefile > has the list of files that must be compiled. Of course, the file was > already compiled in common for u-boot.bin. > > Not sure why this issue appears now. Rebuilding all ARM boards I see > that hawkboard is broken, I have not bisect to check when it happened. Sorry for not having caught this earlier. I ran git bisect on this, and the commit "401bb30b6d replace CONFIG_PRELOADER with CONFIG_SPL_BUILD" seems to be causing the build break. The issue seems to be that the code in board/davinci/common/misc.c gets conditionally compiled based on definition of CONFIG_PRELOADER symbol, which was removed in this commit, and replaced by CONFIG_SPL_BUILD. I think we should correspondingly change this check in misc.c, so that it would not be required to compile in memsize.c. Let me know, and i will test this change and send out a patch. Thanks. -sughosh