From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] led: remove camelcase in LED functions from assembly
Date: Mon, 12 Sep 2011 12:27:20 -0400 [thread overview]
Message-ID: <201109121227.21811.vapier@gentoo.org> (raw)
In-Reply-To: <4E6D9941.6070902@aribaud.net>
On Monday, September 12, 2011 01:31:45 Albert ARIBAUD wrote:
> Le 12/09/2011 06:04, Mike Frysinger a ?crit :
> > On Sunday, September 11, 2011 18:22:26 Jason Kridner wrote:
> >> This was done with the following command-line:
> >>
> >> for file in `find . | grep '\.[chS]$'`;
> >>
> >> do perl -i -pe 's/(green|yellow|red|blue)_LED_(on|off)/$1_led_$2/g'
> >> $file;
> >>
> >> done
> >
> > one line:
> > find . -name '*.[chS]' -exec \
> >
> > sed -ri 's/(green|yellow|red|blue)_LED_(on|off)/\1_led_\2/g'
> >
> >> --- a/arch/arm/cpu/arm1176/start.S
> >> +++ b/arch/arm/cpu/arm1176/start.S
> >>
> >> bl coloured_LED_init
> >>
> >> - bl red_LED_on
> >> + bl red_led_on
> >
> > seems like you didnt fix coloured_LED_init
> >
> > also, i dont see you changing any of the .c files where these funcs are
> > actually defined
>
> This patch is assumed to apply above the current git tip, where the
> function definitions were already changed, and only .S files should be
> fixed.
by "current git tip" i'm guessing you mean "current arm master". i was
looking at the mainline u-boot master and the C files weren't changed.
> Running MAKEALL arm right now, just to make sure, then I will apply it
> on top of u-boot-arm/master.
be nice to send out a single squashed patch to wolfgang rather than a few
known-to-be-broken ones ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110912/b64a0921/attachment.pgp
next prev parent reply other threads:[~2011-09-12 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-11 22:22 [U-Boot] [PATCH] led: remove camelcase in LED functions from assembly Jason Kridner
2011-09-12 4:04 ` Mike Frysinger
2011-09-12 5:31 ` Albert ARIBAUD
2011-09-12 15:40 ` Albert ARIBAUD
2011-09-12 16:27 ` Mike Frysinger [this message]
2011-09-12 19:32 ` Albert ARIBAUD
2011-09-12 20:28 ` Mike Frysinger
2011-09-12 20:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109121227.21811.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox