From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Mon, 12 Sep 2011 19:06:13 +0200
Subject: [U-Boot] [PATCH] net: turn name len check into an assert
In-Reply-To: <201109121229.11257.vapier@gentoo.org>
References: <1315802993-12798-1-git-send-email-vapier@gentoo.org>
	<201109120708.50484.marek.vasut@gmail.com>
	<201109121229.11257.vapier@gentoo.org>
Message-ID: <201109121906.13752.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, September 12, 2011 06:29:10 PM Mike Frysinger wrote:
> On Monday, September 12, 2011 01:08:50 Marek Vasut wrote:
> > On Monday, September 12, 2011 06:49:53 AM Mike Frysinger wrote:
> > > --- a/net/eth.c
> > > +++ b/net/eth.c
> > > 
> > > -	size_t len = strlen(dev->name);
> > > -	if (len >= NAMESIZE) {
> > > -		printf("Network driver name is too long (%zu >= %zu): %s\n",
> > > -						len, NAMESIZE, dev->name);
> > > -		return -1;
> > > -	}
> > > +	assert(strlen(dev->name) < NAMESIZE);
> > 
> > Aren't you changing the logic here ?
> 
> pretty sure it's the same.  old code would warn when "len >= max", while
> mine asserts that "len < max" and thus aborts when "!(len < max)" and
> based on boolean logic, "(x >= y) == !(x < y)".
> -mike

The old code return -1, doesn't abort ;-)