From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 12 Sep 2011 19:45:17 +0200 Subject: [U-Boot] [PATCH 5/5] NAND: Add scrub.quiet command option In-Reply-To: <201109121245.44321.vapier@gentoo.org> References: <1315800250-19761-1-git-send-email-marek.vasut@gmail.com> <1315800250-19761-6-git-send-email-marek.vasut@gmail.com> <201109121245.44321.vapier@gentoo.org> Message-ID: <201109121945.17407.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, September 12, 2011 06:45:43 PM Mike Frysinger wrote: > On Monday, September 12, 2011 00:04:10 Marek Vasut wrote: > > This allows the scrub command to scrub without asking the user if he > > really wants to scrub the area. Useful in scripts. > > "quiet" and "skip user input" are two different things. can you use a more > clean option like accepting "-y" to the "scrub" subcommand ? I'd prefer to have this hidden from common users as much as possible. > > > @@ -569,6 +574,7 @@ int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, > > char * const argv[]) return -1; > > > > } > > > > } > > > > + > > > > ret = nand_erase_opts(nand, &opts); > > printf("%s\n", ret ? "ERROR" : "OK"); > > unrelated whitespace changes are frowned upon > -mike Thanks for finding this. Cheers