[U-Boot] [PATCH 01/15 V3] iMX28: Initial support for iMX28 CPU

Marek Vasut
2011-10-14T07:59:41Z

On Friday, October 14, 2011 09:51:22 AM Stefano Babic wrote:
> On 10/13/2011 08:14 PM, Marek Vasut wrote:
> > Hi Stefano,
> >
> > the patch is big and will need approval to be let into ML. Removing the
> > space in char * const argv[] shall do the trick, can you please do that
> > by hand ?
>
> I have absolutely no intention to push patches without beeing reviewed
> by ML, but I would like to prepare a branch with all your M28 patches to
> check consistency with the rest of code.
>
> Running checkpatch on your patches I see a lot of issues, and not only a
> couple of them.
>
> For example,
>
> WARNING: line over 80 characters
> #632: FILE: arch/arm/cpu/arm926ejs/mx28/mx28.c:150:
> +int do_mx28_showclocks(cmd_tbl_t *cmdtp, int flag, int argc, char *
> const argv[])
>
> WARNING: line over 80 characters
> #5415: FILE: arch/arm/include/asm/arch-mx28/iomux-mx28.h:23:
> + *
> BANK PIN MUX
>
> WARNING: line over 80 characters
> #5418: FILE: arch/arm/include/asm/arch-mx28/iomux-mx28.h:26:
> +#define MX28_PAD_GPMI_D00__GPMI_D0
> MXS_IOMUX_PAD_NAKED(0, 0, PAD_MUXSEL_0)
>
> Running checkpatch on all your patches I get 488 warnings. Can you check
> and fix them ?
>
> Stefano

Stefano,

those iomux-mx28.h issues were already explained. It's a file taken from linux
kernel with no modifications, that's why the issues. And if you take a look
inside, fixing it would make it unreadable.

Cheers