From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 14 Sep 2011 05:14:13 +0200
Subject: [U-Boot] [PATCH 07/15 V2] iMX28: Add SPI driver
In-Reply-To: <201109132250.09750.vapier@gentoo.org>
References: <1315800409-19876-8-git-send-email-marek.vasut@gmail.com>
	<1315952779-4289-1-git-send-email-marek.vasut@gmail.com>
	<201109132250.09750.vapier@gentoo.org>
Message-ID: <201109140514.13704.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, September 14, 2011 04:50:09 AM Mike Frysinger wrote:
> On Tuesday, September 13, 2011 18:26:19 Marek Vasut wrote:
> > +int spi_claim_bus(struct spi_slave *slave)
> > +{
> > +	struct mxs_spi_slave *mxs_slave = to_mxs_slave(slave);
> > +	struct mx28_ssp_regs *ssp_regs = mxs_slave->regs;
> > +	uint32_t reg = 0;
> > +
> > +	mx28_reset_block(&ssp_regs->hw_ssp_ctrl0_reg);
> > +
> > +	writel(SSP_CTRL0_BUS_WIDTH_ONE_BIT, &ssp_regs->hw_ssp_ctrl0);
> > +
> > +	reg = SSP_CTRL1_SSP_MODE_SPI | SSP_CTRL1_WORD_LENGTH_EIGHT_BITS;
> > +	reg |= (mxs_slave->mode & SPI_CPOL) ? SSP_CTRL1_POLARITY : 0;
> > +	reg |= (mxs_slave->mode & SPI_CPHA) ? SSP_CTRL1_PHASE : 0;
> > +	writel(reg, &ssp_regs->hw_ssp_ctrl1);
> > +
> > +	writel(0, &ssp_regs->hw_ssp_cmd0);
> > +
> > +	mx28_set_ssp_busclock(slave->bus, mxs_slave->max_khz);
> 
> this turns on the hardware ...

This only sets up the clock to a correct frequency, the hardware is running all 
the time.
> 
> > +void spi_release_bus(struct spi_slave *slave)
> > +{
> > +}
> 
> ... so shouldn't this turn it off ?
> 
> i dont have the datasheet for the controller, so i have no idea :)
> -mike