From: Zhao Chenhui <b35336@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/9] powerpc/mpc85xxcds: Fix PCI speed
Date: Wed, 14 Sep 2011 18:34:19 +0800 [thread overview]
Message-ID: <20110914103419.GA19095@localhost.localdomain> (raw)
In-Reply-To: <20110913201444.307451408E94@gemini.denx.de>
On Tue, Sep 13, 2011 at 10:14:44PM +0200, Wolfgang Denk wrote:
> Dear Zhao Chenhui,
>
> In message <1315898131-27710-2-git-send-email-chenhui.zhao@freescale.com> you wrote:
> ...
> > printf("PCI1: %d bit, %s MHz, %s\n",
> > (pci1_32) ? 32 : 64,
> > - (pci1_speed == 33000000) ? "33" :
> > - (pci1_speed == 66000000) ? "66" : "unknown",
> > + (pci1_speed == 33333333) ? "33" :
> > + (pci1_speed == 66666666) ? "66" : "unknown",
> > pci1_clk_sel ? "sync" : "async");
>
> Why cannot you simply write:
>
> ...
> char buf[32];
> ...
> printf("PCI1: %d bit, %s MHz, %ssync\n",
> (pci1_32) ? 32 : 64,
> strmhz(buf, pci1_speed),
> pci1_clk_sel ? "" : "a");
>
> ?
>
>
> Best regards,
>
> Wolfgang Denk
>
Yes. I'll repost it.
-chenhui
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> The only time the world beats a path to your door is when you are in
> the bathroom.
>
next prev parent reply other threads:[~2011-09-14 10:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 7:15 [U-Boot] [PATCH 1/9] powerpc/mpc8548cds: Fix booting message Zhao Chenhui
2011-09-13 7:15 ` [U-Boot] [PATCH 2/9] powerpc/mpc85xxcds: Fix PCI speed Zhao Chenhui
2011-09-13 9:57 ` Wolfgang Denk
2011-09-13 19:20 ` Tabi Timur-B04825
2011-09-13 20:02 ` Scott Wood
2011-09-13 20:03 ` Timur Tabi
2011-09-13 20:14 ` Scott Wood
2011-09-13 20:18 ` Timur Tabi
2011-09-14 11:36 ` Zhao Chenhui
2011-09-13 20:14 ` Wolfgang Denk
2011-09-14 10:34 ` Zhao Chenhui [this message]
2011-09-13 7:15 ` [U-Boot] [PATCH 3/9] powerpc/mpc8548: Add workaround for erratum NMG_DDR120 Zhao Chenhui
2011-10-03 13:33 ` Kumar Gala
2011-09-13 7:15 ` [U-Boot] [PATCH 4/9] powerpc/mpc8548: Add workaround for erratum NMG_eTSEC129 Zhao Chenhui
2011-11-08 14:32 ` Kumar Gala
2011-09-13 7:15 ` [U-Boot] [PATCH 5/9] powerpc/mpc8548cds: Fix network initialization Zhao Chenhui
2011-11-08 14:32 ` Kumar Gala
2011-09-13 7:15 ` [U-Boot] [PATCH 6/9] powerpc/mpc8548cds: Update config file Zhao Chenhui
2011-09-13 16:09 ` Tabi Timur-B04825
2011-10-06 21:33 ` Wolfgang Denk
2011-10-07 15:11 ` Kumar Gala
2011-10-09 18:26 ` Wolfgang Denk
2011-10-07 15:15 ` Kumar Gala
2011-09-13 7:15 ` [U-Boot] [PATCH 7/9] powerpc/mpc8548: Add workaround for erratum NMG_LBC103 Zhao Chenhui
2011-10-03 13:39 ` Kumar Gala
2011-09-13 7:15 ` [U-Boot] [PATCH 8/9] powerpc/mpc8548cds: Fix config according to system address map Zhao Chenhui
2011-10-07 15:17 ` Kumar Gala
2011-10-08 7:02 ` Zhao Chenhui
2011-10-08 7:47 ` Zhao Chenhui
2011-09-13 7:15 ` [U-Boot] [PATCH 9/9] powerpc/mpc8548cds: Add 36-bit support Zhao Chenhui
2011-10-03 13:28 ` [U-Boot] [PATCH 1/9] powerpc/mpc8548cds: Fix booting message Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110914103419.GA19095@localhost.localdomain \
--to=b35336@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox