From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Sat, 17 Sep 2011 20:02:47 -0400
Subject: [U-Boot] [RFC PATCH 05/20] sandbox: Add architecture lib files
In-Reply-To: <1316278139-28635-6-git-send-email-sjg@chromium.org>
References: <1316278139-28635-2-git-send-email-sjg@chromium.org>
	<1316278139-28635-6-git-send-email-sjg@chromium.org>
Message-ID: <201109172002.49438.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Saturday, September 17, 2011 12:48:44 Simon Glass wrote:
> These files are taken from the ARM board implementation and then reduced
> to remove unneeded cr!uft.

"cr!uft" -> "cruft"

> --- /dev/null
> +++ b/arch/sandbox/lib/Makefile
>
> +LIBGCC	= $(obj)libgcc.o
>
> +LGOBJS	:= $(addprefix $(obj),$(GLSOBJS)) \
> +	   $(addprefix $(obj),$(GLCOBJS))
>
> +# Build private libgcc only when asked for
> +ifdef USE_PRIVATE_LIBGCC
> +TARGETS	+= $(LIBGCC)
> +endif
>
> +$(LIBGCC): $(obj).depend $(LGOBJS)
> +	$(call cmd_link_o_target, $(LGOBJS))

i think this is arm cruft that should get scrubbed here

> --- /dev/null
> +++ b/arch/sandbox/lib/board.c
>
> +#ifndef CONFIG_IDENT_STRING
> +#define CONFIG_IDENT_STRING ""
> +#endif
> +
> +const char version_string[] =
> +	U_BOOT_VERSION" (" U_BOOT_DATE " - " U_BOOT_TIME ")"CONFIG_IDENT_STRING;

common code takes care of this for you already, so just delete it

> +static int display_banner(void)
> +{
> +	printf("\n\n%s\n\n", version_string);

call display_options() instead of writing version_string yourself

> +static int display_dram_config(void)

is any of this dram logic needed ?  looks like an ARM wart that should get 
removed from all the sandbox code.

> +#if !defined(CONFIG_SYS_NO_FLASH)
> +static char *failed = "*** failed ***\n";
> +#endif

i dont see this getting used anywhere, so punt it
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110917/4c636a31/attachment.pgp