[U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files

Simon Glass
2011-09-23T15:54:06Z

Hi Mike,

On Sat, Sep 17, 2011 at 4:58 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Saturday, September 17, 2011 12:48:43 Simon Glass wrote:
>> --- /dev/null
>> +++ b/arch/sandbox/config.mk
>>
>> +LDSCRIPT := $(SRCTREE)/$(CPUDIR)/u-boot.lds
>
> the top level Makefile should take care of this for you so you can just delete
> this line
>
>> --- /dev/null
>> +++ b/arch/sandbox/cpu/sandbox/cpu.c
>>
>> +int do_reset(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>> +{
>> + ? ? return -1;
>> +}
>
> do_reset() is not supposed to return

I have adjusted the function meaning (which luckily for me was not
defined) so that it can return -1 on failure. This makes my code
correct :-)

I think it is reasonable to provide a reset function which might not
be able to do its job. That is the current state of sandbox.

Regards,
Simon

> -mike
>