[U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files

Simon Glass
2011-09-25T20:18:32Z

Hi Wolfgang,

On Sun, Sep 25, 2011 at 12:25 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Simon Glass,
>
> In message <CAPnjgZ1FfRPbU9gtxp9qVM24Ln2R-bWU1OjmrL3E+hijjLwiNQ@mail.gmail.com> you wrote:
>>
>> > do_reset() is not supposed to return
>>
>> I have adjusted the function meaning (which luckily for me was not
>> defined) so that it can return -1 on failure. This makes my code
>> correct :-)
>>
>> I think it is reasonable to provide a reset function which might not
>> be able to do its job. That is the current state of sandbox.
>
> No, I don't want to change the current definition of reset().

OK.

>
>
> And "not able to do the job" is something different than
> "unimplemented".
>
> Why cannot we do a real reset here? Re-exec'in the running binary or
> performing a longjmp() to the start might be ideas how to implement
> this.

While this could be done I believe that it might be possible /
desirable to exit out of the main loop, rather than longjmp or
re-exec. I have not implemented it because I have not got to that bit
yet and don't want to put time into a solution I will throw away.

I'm happy to just put:

while (1) ;

in the reset code if you like?

Regards,
Simon

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, ? ? MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "The value of marriage is not that adults produce children, but ?that
> children produce adults." ? ? ? ? ? ? ? ? ? ? ? ? ? ?- Peter De Vries
>