From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] punt unused clean/distclean targets
Date: Sun, 18 Sep 2011 04:22:06 -0400 [thread overview]
Message-ID: <201109180422.09040.vapier@gentoo.org> (raw)
In-Reply-To: <20110918072638.B80471407963@gemini.denx.de>
On Sunday, September 18, 2011 03:26:38 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > The top level Makefile does not do any recursion into subdirs when
> > cleaning, so these clean/distclean targets in random arch/board dirs
> > never get used. Punt them all.
>
> I think this is the wrong approach. Would it not be better to get rid
> of the 60 lines of clean/clobber target in the top level Makefile,
> including it's brute force methods of "find ... | xargs rm -f" and
> actually remove the files from the Makefiles in the respective
> directories instead?
>
> This would for example allow that a board maintainer can fix the clean
> / clobber rules for his code without having to edit the top level
> Makefile.
yes & no. i think we should have 1 clean/distclean target, but also have a
way for board maintainers to inject their own custom clean files. preferably
via a .mk file in their board subdir. this is moving in the direction of non-
recursive make like the kernel does -- the top level would source all the
subfiles to figure out the master clean list.
however, the current build system has one advantage which i think we should
retain in the short term: `make distclean` always cleans out the targets
regardless of the current config. for example, if you do `make bf537-stamp`
followed by `make harmony` followed by `make distclean`, Blackfin-specific
objects will still get cleaned out.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110918/5e992134/attachment.pgp
next prev parent reply other threads:[~2011-09-18 8:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 5:17 [U-Boot] [PATCH] punt unused clean/distclean targets Mike Frysinger
2011-09-18 7:26 ` Wolfgang Denk
2011-09-18 8:22 ` Mike Frysinger [this message]
2011-09-18 13:08 ` Graeme Russ
2011-09-19 4:59 ` Mike Frysinger
2011-09-19 5:10 ` Marek Vasut
2011-09-19 5:30 ` Mike Frysinger
2011-09-19 6:57 ` Wolfgang Denk
2011-09-19 5:11 ` Graeme Russ
2011-09-19 5:32 ` Mike Frysinger
2011-09-19 6:54 ` Wolfgang Denk
2011-09-19 14:28 ` Mike Frysinger
2011-09-19 18:29 ` Scott Wood
2011-09-19 20:57 ` [U-Boot] serial ifdef mess Mike Frysinger
2011-09-20 0:41 ` Graeme Russ
2011-09-20 0:52 ` Mike Frysinger
2011-09-20 1:07 ` Graeme Russ
2011-09-20 4:28 ` Simon Glass
2011-09-20 4:44 ` Mike Frysinger
2011-09-20 5:12 ` Graeme Russ
2011-09-20 7:29 ` Wolfgang Denk
2011-09-20 4:40 ` Mike Frysinger
2011-10-13 16:54 ` [U-Boot] [PATCH v2] punt unused clean/distclean targets Mike Frysinger
2011-10-15 20:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109180422.09040.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox