From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] serial ifdef mess
Date: Mon, 19 Sep 2011 20:52:28 -0400 [thread overview]
Message-ID: <201109192052.30059.vapier@gentoo.org> (raw)
In-Reply-To: <CALButC+5bFyM=Wc10o4P2weapD_r1FDFBiVckepZTHs1g=Buuw@mail.gmail.com>
On Monday, September 19, 2011 20:41:20 Graeme Russ wrote:
> Hi Mike,
>
> On Tue, Sep 20, 2011 at 6:57 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Sunday, September 18, 2011 09:08:35 Graeme Russ wrote:
> >> I mean, it irks me to no end that /common/serial.c, /drivers/serial.c
> >> and /include/serial.h are such an ugly mess of #ifdef's - I'm working
> >> on a new SoC at the moment, and it just plain weird that I have to
> >> touch these :(
> >
> > well, there's two things there. the init mess which could get fixed in
> > two diff ways: part of your larger init cleanup, or turn it into board
> > callbacks like most of the other frameworks we have atm.
>
> I don't think the serial mess is related to the init sequence at all (but
> I could be wrong)
the only way to register a new serial device is to add a call to it in
common/serial.c:serial_initialize(). and the only thing that func does is
call all the various register funcs which are simply init calls.
> > the second thing is the CONFIG_SERIAL_MULTI hell. that mess i'd like to
> > gut with a dull blade at some point.
>
> Or a sledgehammer!
>
> The big question I suppose is where we are at with the _MULTI interfaces.
> From what I can gather, these should now be the only ones in use and we
> should start to apply pressure on board maintainers (i.e. break their
> boards) to fix any depricated usage. I think the same philosophy should
> be applied to the various boards with 'flash.c' which should all be
> using CFI by now.
i dont have a problem with non-multi instances since it produces thinner code
i dont think there is anyone driving the serial core atm though ... i dont
recall seeing any patches there other than new device drivers since ive been
watching the list ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110919/898aa680/attachment.pgp
next prev parent reply other threads:[~2011-09-20 0:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-18 5:17 [U-Boot] [PATCH] punt unused clean/distclean targets Mike Frysinger
2011-09-18 7:26 ` Wolfgang Denk
2011-09-18 8:22 ` Mike Frysinger
2011-09-18 13:08 ` Graeme Russ
2011-09-19 4:59 ` Mike Frysinger
2011-09-19 5:10 ` Marek Vasut
2011-09-19 5:30 ` Mike Frysinger
2011-09-19 6:57 ` Wolfgang Denk
2011-09-19 5:11 ` Graeme Russ
2011-09-19 5:32 ` Mike Frysinger
2011-09-19 6:54 ` Wolfgang Denk
2011-09-19 14:28 ` Mike Frysinger
2011-09-19 18:29 ` Scott Wood
2011-09-19 20:57 ` [U-Boot] serial ifdef mess Mike Frysinger
2011-09-20 0:41 ` Graeme Russ
2011-09-20 0:52 ` Mike Frysinger [this message]
2011-09-20 1:07 ` Graeme Russ
2011-09-20 4:28 ` Simon Glass
2011-09-20 4:44 ` Mike Frysinger
2011-09-20 5:12 ` Graeme Russ
2011-09-20 7:29 ` Wolfgang Denk
2011-09-20 4:40 ` Mike Frysinger
2011-10-13 16:54 ` [U-Boot] [PATCH v2] punt unused clean/distclean targets Mike Frysinger
2011-10-15 20:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109192052.30059.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox