From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4 V4] I2C: mxc_i2c rework
Date: Thu, 22 Sep 2011 07:47:06 +0200 [thread overview]
Message-ID: <201109220747.06315.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAFQ4atSkGO6vFmF6aoLPYZP7gTLEQteVLU3HQ6AeMf9DgBPraQ@mail.gmail.com>
On Thursday, September 22, 2011 06:54:22 AM Jason Hui wrote:
> Hi, Marek,
>
> On Thu, Sep 22, 2011 at 11:43 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > On Thursday, September 22, 2011 04:45:20 AM Jason Hui wrote:
> >> Hi, Marek,
> >>
> >> On Tue, Sep 20, 2011 at 10:35 AM, Marek Vasut <marek.vasut@gmail.com>
wrote:
> >> > Rewrite the mxc_i2c driver.
> >> > * This version is much closer to Linux implementation.
> >> > * Fixes IPG_PERCLK being incorrectly used as clock source
> >> > * Fixes behaviour of the driver on iMX51
> >> > * Clean up coding style a bit ;-)
> >> >
> >> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >> > Cc: Stefano Babic <sbabic@denx.de>
> >> > Cc: Heiko Schocher <hs@denx.de>
> >> > Cc: Jason Hui <jason.hui@linaro.org>
> >> > ---
> >> > drivers/i2c/mxc_i2c.c | 422
> >> > +++++++++++++++++++++++++++++++++---------------- 1 files changed, 289
> >> > insertions(+), 133 deletions(-)
> >> >
> >> > V2: Use PERCLK as a source.
> >> >
> >> > V3: Remove forgotten unused variables.
> >> >
> >> > V4: Add missing Cc field to commit message
> >>
> >> Test result on i.mx53evk, it shows that this patch does not work well,
> >> here is the log:
> >>
> >> MX53EVK U-Boot > pmic dump 10
> >> PMIC ID: 0x0000ffff [Rev: unknown]
> >>
> >> 0x00: 0001ffff 00ffffff 0039ffff 0000ffff 00ffffff 0000ffff 0000ffff
> >> 0000ffff 0x08: 0000ffff 0000ffff 0000ffff 0000ffff 0000ffff 0000ffff
> >> 0000ffff 0040ffff
> >
> > It's strange, reading the registers with i2c md seems to work.
>
> Here is i2c md output:
> MX53EVK U-Boot > i2c md 8 0
> 0000: 01 ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
>
> seems not ok.
8 seems certainly not ok since the pmic is at 0x48
>
> Jason Liu
next prev parent reply other threads:[~2011-09-22 5:47 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 0:09 [U-Boot] [PATCH 0/4] Clock fix and MXC I2C rework series Marek Vasut
2011-09-15 0:09 ` [U-Boot] [PATCH 1/4] MX5: Modify the PLL decoding algorithm Marek Vasut
2011-09-22 3:20 ` Jason Hui
2011-09-23 9:15 ` Stefano Babic
2011-09-23 9:43 ` [U-Boot] [PATCH 1/4 V2] " Marek Vasut
2011-09-15 0:09 ` [U-Boot] [PATCH 2/4] MX5: Add AHB clock reporting and fix IPG clock reporting Marek Vasut
2011-09-22 3:05 ` Jason Hui
2011-09-22 3:41 ` Marek Vasut
2011-09-22 4:46 ` Jason Hui
2011-09-22 19:20 ` [U-Boot] [PATCH 2/4 V2] " Marek Vasut
2011-09-23 2:09 ` Jason Hui
2011-09-15 0:09 ` [U-Boot] [PATCH 3/4] MX5: Clean up the output of "clocks" command Marek Vasut
2011-09-19 10:03 ` Stefano Babic
2011-09-22 1:58 ` Jason Hui
2011-09-15 0:09 ` [U-Boot] [PATCH 4/4] I2C: mxc_i2c rework Marek Vasut
2011-09-15 4:16 ` [U-Boot] [PATCH 4/4 V2] " Marek Vasut
2011-09-19 6:13 ` Heiko Schocher
2011-09-20 2:30 ` [U-Boot] [PATCH 4/4 V3] " Marek Vasut
2011-09-20 2:35 ` [U-Boot] [PATCH 4/4 V4] " Marek Vasut
2011-09-22 2:45 ` Jason Hui
2011-09-22 3:43 ` Marek Vasut
2011-09-22 4:54 ` Jason Hui
2011-09-22 5:47 ` Marek Vasut [this message]
2011-09-22 6:49 ` Jason Hui
2011-09-22 19:22 ` [U-Boot] [PATCH 4/4 V5] " Marek Vasut
2011-09-23 3:32 ` Jason Hui
2011-09-23 4:31 ` Fabio Estevam
2011-09-23 6:21 ` Marek Vasut
2011-09-23 7:46 ` Stefano Babic
2011-09-26 6:30 ` Heiko Schocher
2011-10-14 16:28 ` Anatolij Gustschin
2011-09-19 10:11 ` [U-Boot] [PATCH 4/4] " Stefano Babic
2011-09-19 10:24 ` Marek Vasut
2011-09-20 10:07 ` Jason Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109220747.06315.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox