public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI
Date: Sat, 24 Sep 2011 18:50:43 +0200	[thread overview]
Message-ID: <201109241850.43210.marek.vasut@gmail.com> (raw)
In-Reply-To: <CANqCtQKrXch2sNTpn48kDV6tx5jQX-ysnZD9DkXTTYRitYFcaA@mail.gmail.com>

On Saturday, September 24, 2011 06:41:58 PM Remy Bohmer wrote:
> Hi,
> 
> 2011/9/23 Marek Vasut <marek.vasut@gmail.com>:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Remy Bohmer <linux@bohmer.net>
> > ---
> >  drivers/usb/host/ehci-hcd.c |   33 ++++++++++++++++++++++++++++++++-
> >  1 files changed, 32 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> > index 52b98c2..5b53b3a 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -27,6 +27,10 @@
> >  #include <malloc.h>
> >  #include <watchdog.h>
> >  #include <usb/ehci-fsl.h>
> > +#ifdef CONFIG_USB_KEYBOARD
> > +#include <stdio_dev.h>
> > +extern unsigned char new[];
> > +#endif
> > 
> >  #include "ehci.h"
> > 
> > @@ -914,5 +918,32 @@ submit_int_msg(struct usb_device *dev, unsigned long
> > pipe, void *buffer,
> > 
> >        debug("dev=%p, pipe=%lu, buffer=%p, length=%d, interval=%d",
> >              dev, pipe, buffer, length, interval);
> > -       return -1;
> > +       return ehci_submit_async(dev, pipe, buffer, length, NULL);
> 
> Why is changing this line needed?

To actually submit the interrupt request ?

> 
> > +}
> > +
> > +#ifdef CONFIG_SYS_USB_EVENT_POLL
> > +/*
> > + * This function polls for USB keyboard data.
> > + */
> > +void usb_event_poll()
> > +{
> > +       struct stdio_dev *dev;
> > +       struct usb_device *usb_kbd_dev;
> > +       struct usb_interface *iface;
> > +       struct usb_endpoint_descriptor *ep;
> > +       int pipe;
> > +       int maxp;
> > +
> > +       /* Get the pointer to USB Keyboard device pointer */
> > +       dev = stdio_get_by_name("usbkbd");
> > +       usb_kbd_dev = (struct usb_device *)dev->priv;
> > +       iface = &usb_kbd_dev->config.if_desc[0];
> > +       ep = &iface->ep_desc[0];
> > +       pipe = usb_rcvintpipe(usb_kbd_dev, ep->bEndpointAddress);
> > +
> > +       /* Submit a interrupt transfer request */
> > +       maxp = usb_maxpacket(usb_kbd_dev, pipe);
> > +       usb_submit_int_msg(usb_kbd_dev, pipe, &new[0],
> > +                       maxp > 8 ? 8 : maxp, ep->bInterval);
> >  }
> > +#endif /* CONFIG_SYS_USB_EVENT_POLL */
> 
> Patch does not apply to u-boot-usb master.
> Please rebase this patch.

Ah right ... there must be some changes in my repo or u-boot-imx/next ... will 
do in my next submission round.

Cheers

> 
> Kind regards,
> 
> Remy

  reply	other threads:[~2011-09-24 16:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23 15:36 [U-Boot] [PATCH] USB: Add usb_event_poll() to get keyboards working with EHCI Marek Vasut
2011-09-24 16:41 ` Remy Bohmer
2011-09-24 16:50   ` Marek Vasut [this message]
2011-09-24 16:56     ` Remy Bohmer
2011-09-25 19:07 ` [U-Boot] [PATCH V2] " Marek Vasut
2011-10-06 21:21   ` Wolfgang Denk
2011-10-06 23:30     ` Marek Vasut
2011-10-07  5:25       ` Wolfgang Denk
2011-10-07  8:55         ` Marek Vasut
2011-10-08 18:27           ` Remy Bohmer
2011-10-08 18:28   ` Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109241850.43210.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox