[U-Boot] [PATCH 1/4] zmx25: Remove dram_init_banksize()

[U-Boot] [PATCH 1/4] zmx25: Remove dram_init_banksize()

[Fabio Estevam]

As only one RAM bank is used we can rely on the code from arch/arm/lib/board.c

Cc: Matthias Weisser <weisserm@arcor.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/syteco/zmx25/zmx25.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/board/syteco/zmx25/zmx25.c b/board/syteco/zmx25/zmx25.c
index 893adc6..a49d831 100644
--- a/board/syteco/zmx25/zmx25.c
+++ b/board/syteco/zmx25/zmx25.c
@@ -188,9 +188,3 @@ int dram_init(void)
 				PHYS_SDRAM_SIZE);
 	return 0;
 }
-
-void dram_init_banksize(void)
-{
-	gd->bd->bi_dram[0].start = PHYS_SDRAM;
-	gd->bd->bi_dram[0].size = gd->ram_size;
-}
-- 
1.6.0.4

[U-Boot] [PATCH 2/4] zmx25: Place machine ID into board config

[Fabio Estevam]

Let common code set the machine ID.

Cc: Matthias Weisser <weisserm@arcor.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/syteco/zmx25/zmx25.c |    2 --
 include/configs/zmx25.h    |    1 +
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/board/syteco/zmx25/zmx25.c b/board/syteco/zmx25/zmx25.c
index a49d831..a89ee1a 100644
--- a/board/syteco/zmx25/zmx25.c
+++ b/board/syteco/zmx25/zmx25.c
@@ -117,8 +117,6 @@ int board_init()
 	writel(input_select1, &inputselect->i2c3_ipp_sda_in);	/* I2C3 SDA */
 	writel(input_select2, &inputselect->i2c3_ipp_scl_in);	/* I2C3 SCL */
 
-	/* board id for linux */
-	gd->bd->bi_arch_number = MACH_TYPE_ZMX25;
 	gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
 
 	return 0;
diff --git a/include/configs/zmx25.h b/include/configs/zmx25.h
index 0c217b8..70c85ac 100644
--- a/include/configs/zmx25.h
+++ b/include/configs/zmx25.h
@@ -34,6 +34,7 @@
 
 #define CONFIG_DISPLAY_CPUINFO
 
+#define CONFIG_MACH_TYPE	MACH_TYPE_ZMX25
 /*
  * Environment settings
  */
-- 
1.6.0.4

[U-Boot] [PATCH 3/4] vision2: Place machine ID into board config

[Fabio Estevam]

Let common code set the machine ID.

Cc: Stefano Babic <sbabic@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/ttcontrol/vision2/vision2.c |    1 -
 include/configs/vision2.h         |    2 ++
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/board/ttcontrol/vision2/vision2.c b/board/ttcontrol/vision2/vision2.c
index 17a2558..ebca7b6 100644
--- a/board/ttcontrol/vision2/vision2.c
+++ b/board/ttcontrol/vision2/vision2.c
@@ -653,7 +653,6 @@ void lcd_enable(void)
 
 int board_init(void)
 {
-	gd->bd->bi_arch_number = MACH_TYPE_TTC_VISION2;	/* board id for linux */
 	/* address of boot parameters */
 	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
 
diff --git a/include/configs/vision2.h b/include/configs/vision2.h
index b5c7357..16881a9 100644
--- a/include/configs/vision2.h
+++ b/include/configs/vision2.h
@@ -41,6 +41,8 @@
 #define CONFIG_INITRD_TAG
 #define BOARD_LATE_INIT
 
+#define CONFIG_MACH_TYPE	MACH_TYPE_TTC_VISION2
+
 /*
  * Size of malloc() pool
  */
-- 
1.6.0.4

[U-Boot] [PATCH 4/4] efikamx: Place machine ID into board config

[Fabio Estevam]

Let common code set the machine ID.

Cc: Marek Vasut <marek.vasut@gmail.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/efikamx/efikamx.c   |    1 -
 include/configs/efikamx.h |    2 ++
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/board/efikamx/efikamx.c b/board/efikamx/efikamx.c
index 5be1f6c..be2a9a1 100644
--- a/board/efikamx/efikamx.c
+++ b/board/efikamx/efikamx.c
@@ -607,7 +607,6 @@ int board_early_init_f(void)
 
 int board_init(void)
 {
-	gd->bd->bi_arch_number = MACH_TYPE_MX51_EFIKAMX;
 	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
 
 	return 0;
diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
index fdd0a14..0b5d2dc 100644
--- a/include/configs/efikamx.h
+++ b/include/configs/efikamx.h
@@ -40,6 +40,8 @@
 
 #define CONFIG_SYS_TEXT_BASE		0x97800000
 
+#define CONFIG_MACH_TYPE	MACH_TYPE_MX51_EFIKAMX
+
 /*
  * Bootloader Components Configuration
  */
-- 
1.6.0.4

[U-Boot] [PATCH 4/4] efikamx: Place machine ID into board config

[Marek Vasut]

On Friday, September 23, 2011 02:50:52 PM Fabio Estevam wrote:
> Let common code set the machine ID.
> 

This will need rework ... stefano, can we get the efikasb stuff mainline so 
Fabio can rework this ?

Cheers

> Cc: Marek Vasut <marek.vasut@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/efikamx/efikamx.c   |    1 -
>  include/configs/efikamx.h |    2 ++
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/board/efikamx/efikamx.c b/board/efikamx/efikamx.c
> index 5be1f6c..be2a9a1 100644
> --- a/board/efikamx/efikamx.c
> +++ b/board/efikamx/efikamx.c
> @@ -607,7 +607,6 @@ int board_early_init_f(void)
> 
>  int board_init(void)
>  {
> -	gd->bd->bi_arch_number = MACH_TYPE_MX51_EFIKAMX;
>  	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
> 
>  	return 0;
> diff --git a/include/configs/efikamx.h b/include/configs/efikamx.h
> index fdd0a14..0b5d2dc 100644
> --- a/include/configs/efikamx.h
> +++ b/include/configs/efikamx.h
> @@ -40,6 +40,8 @@
> 
>  #define CONFIG_SYS_TEXT_BASE		0x97800000
> 
> +#define CONFIG_MACH_TYPE	MACH_TYPE_MX51_EFIKAMX
> +
>  /*
>   * Bootloader Components Configuration
>   */

[U-Boot] [PATCH 4/4] efikamx: Place machine ID into board config

[Stefano Babic]

On 09/23/2011 03:36 PM, Marek Vasut wrote:
> On Friday, September 23, 2011 02:50:52 PM Fabio Estevam wrote:
>> Let common code set the machine ID.
>>
> 
> This will need rework ... stefano, can we get the efikasb stuff mainline so 
> Fabio can rework this ?

No..it is not a good idea to push a patch that is already required to be
changed.

As this patch addresses a comment in the EfikaMX/SB patchset, the best
way is to fix this issue directly in that patchset.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 3/4] vision2: Place machine ID into board config

[stefano babic]

Am 23/09/2011 14:50, schrieb Fabio Estevam:
> Let common code set the machine ID.
>
> Cc: Stefano Babic <sbabic@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/ttcontrol/vision2/vision2.c |    1 -
>  include/configs/vision2.h         |    2 ++
>  2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/board/ttcontrol/vision2/vision2.c b/board/ttcontrol/vision2/vision2.c
> index 17a2558..ebca7b6 100644
> --- a/board/ttcontrol/vision2/vision2.c
> +++ b/board/ttcontrol/vision2/vision2.c
> @@ -653,7 +653,6 @@ void lcd_enable(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_arch_number = MACH_TYPE_TTC_VISION2;	/* board id for linux */
>  	/* address of boot parameters */
>  	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>  
> diff --git a/include/configs/vision2.h b/include/configs/vision2.h
> index b5c7357..16881a9 100644
> --- a/include/configs/vision2.h
> +++ b/include/configs/vision2.h
> @@ -41,6 +41,8 @@
>  #define CONFIG_INITRD_TAG
>  #define BOARD_LATE_INIT
>  
> +#define CONFIG_MACH_TYPE	MACH_TYPE_TTC_VISION2
> +
>  /*
>   * Size of malloc() pool
>   */

Acked-by: Stefano Babic <sbabic@denx.de>

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 4/4] efikamx: Place machine ID into board config

[Marek Vasut]

On Friday, September 23, 2011 04:17:28 PM Stefano Babic wrote:
> On 09/23/2011 03:36 PM, Marek Vasut wrote:
> > On Friday, September 23, 2011 02:50:52 PM Fabio Estevam wrote:
> >> Let common code set the machine ID.
> > 
> > This will need rework ... stefano, can we get the efikasb stuff mainline
> > so Fabio can rework this ?
> 
> No..it is not a good idea to push a patch that is already required to be
> changed.
> 
> As this patch addresses a comment in the EfikaMX/SB patchset, the best
> way is to fix this issue directly in that patchset.

I also added that machine_is_() things so we'll have that all. Eventually, I 
plan to add MX/SB runtime detection, but that's not in place so far.

> 
> Best regards,
> Stefano Babic

[U-Boot] [PATCH 4/4] efikamx: Place machine ID into board config

[stefano babic]

Am 25/09/2011 01:26, schrieb Marek Vasut:
> On Friday, September 23, 2011 04:17:28 PM Stefano Babic wrote:
>> On 09/23/2011 03:36 PM, Marek Vasut wrote:
>>> On Friday, September 23, 2011 02:50:52 PM Fabio Estevam wrote:
>>>> Let common code set the machine ID.
>>>
>>> This will need rework ... stefano, can we get the efikasb stuff mainline
>>> so Fabio can rework this ?
>>
>> No..it is not a good idea to push a patch that is already required to be
>> changed.
>>
>> As this patch addresses a comment in the EfikaMX/SB patchset, the best
>> way is to fix this issue directly in that patchset.
> 
> I also added that machine_is_() things so we'll have that all. Eventually, I 
> plan to add MX/SB runtime detection, but that's not in place so far.

Ok . So I will take patches 1..3 of this patchset, and you take care of
Eifika board.

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH 4/4] efikamx: Place machine ID into board config

[Marek Vasut]

On Sunday, September 25, 2011 11:43:26 AM stefano babic wrote:
> Am 25/09/2011 01:26, schrieb Marek Vasut:
> > On Friday, September 23, 2011 04:17:28 PM Stefano Babic wrote:
> >> On 09/23/2011 03:36 PM, Marek Vasut wrote:
> >>> On Friday, September 23, 2011 02:50:52 PM Fabio Estevam wrote:
> >>>> Let common code set the machine ID.
> >>> 
> >>> This will need rework ... stefano, can we get the efikasb stuff
> >>> mainline so Fabio can rework this ?
> >> 
> >> No..it is not a good idea to push a patch that is already required to be
> >> changed.
> >> 
> >> As this patch addresses a comment in the EfikaMX/SB patchset, the best
> >> way is to fix this issue directly in that patchset.
> > 
> > I also added that machine_is_() things so we'll have that all.
> > Eventually, I plan to add MX/SB runtime detection, but that's not in
> > place so far.
> 
> Ok . So I will take patches 1..3 of this patchset, and you take care of
> Eifika board.

I'm all for it.
> 
> Best regards,
> Stefano Babic

[U-Boot] [PATCH 1/4] zmx25: Remove dram_init_banksize()

[Stefano Babic]

On 09/23/2011 02:50 PM, Fabio Estevam wrote:
> As only one RAM bank is used we can rely on the code from arch/arm/lib/board.c
> 
> Cc: Matthias Weisser <weisserm@arcor.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/syteco/zmx25/zmx25.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
> 
> diff --git a/board/syteco/zmx25/zmx25.c b/board/syteco/zmx25/zmx25.c
> index 893adc6..a49d831 100644
> --- a/board/syteco/zmx25/zmx25.c
> +++ b/board/syteco/zmx25/zmx25.c
> @@ -188,9 +188,3 @@ int dram_init(void)
>  				PHYS_SDRAM_SIZE);
>  	return 0;
>  }
> -
> -void dram_init_banksize(void)
> -{
> -	gd->bd->bi_dram[0].start = PHYS_SDRAM;
> -	gd->bd->bi_dram[0].size = gd->ram_size;
> -}

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================