From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 18/20] sandbox: Remove unused variable warnings
Date: Mon, 26 Sep 2011 00:49:59 -0400 [thread overview]
Message-ID: <201109260050.00767.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ1hOg1xiGYjxiWLFKKPz3MvA8hGpP2DPGHigYBERZNULw@mail.gmail.com>
On Friday, September 23, 2011 12:01:46 Simon Glass wrote:
> On Sat, Sep 17, 2011 at 5:25 PM, Mike Frysinger wrote:
> > On Saturday, September 17, 2011 12:48:57 Simon Glass wrote:
> >> There are a few variables set but not used - this marks these as unused
> >> for the compiler.
> >
> > summary says "sandbox:" but i dont think this has anything to do with
> > sandbox. you're just using a newer compiler.
> >
> >> --- a/common/cmd_mem.c
> >> +++ b/common/cmd_mem.c
> >>
> >> - ulong addr, length, i, junk;
> >> + ulong addr, length, i, junk __attribute__((unused));
> >
> > this one is tricky as we just want to read the value from the volatile
> > pointer. i'm guessing do "*longp++;" just adds a different warning ?
>
> Isn't that a nop?
if it's volatile, it shouldn't be
> Well I can just assign it to a different variable - I will use 'size'
> in my new patch set.
Marek Vasut posted a patch which dropped the assignment and it seems to not
add any warnings
> >> --- a/common/cmd_nvedit.c
> >> +++ b/common/cmd_nvedit.c
> >>
> >> - int len;
> >> + int len __attribute((unused));
> >
> > this file though looks like we should just delete "len"
>
> Yes, done. I don't use lint anyway.
he also posted a fix for this :)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110926/624ffbd9/attachment.pgp
next prev parent reply other threads:[~2011-09-26 4:49 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-17 16:48 [U-Boot] [RFC PATCH 01/20] sandbox: Add architecture header files Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 02/20] sandbox: Add architecture image support Simon Glass
2011-09-17 19:29 ` Marek Vasut
2011-09-18 3:57 ` Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 03/20] sandbox: Add compiler defines to support a 64-bit x86_64 platform Simon Glass
2011-09-17 23:56 ` Mike Frysinger
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 04/20] sandbox: Add cpu files Simon Glass
2011-09-17 23:58 ` Mike Frysinger
2011-09-23 15:54 ` Simon Glass
2011-09-25 19:25 ` Wolfgang Denk
2011-09-25 20:18 ` Simon Glass
2011-09-26 4:48 ` Mike Frysinger
2011-09-26 16:49 ` Simon Glass
2011-09-26 17:10 ` Anton Staaf
2011-09-26 19:11 ` Simon Glass
2011-09-26 18:12 ` Wolfgang Denk
2011-09-26 18:16 ` Mike Frysinger
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 05/20] sandbox: Add architecture lib files Simon Glass
2011-09-18 0:02 ` Mike Frysinger
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 06/20] sandbox: Allow board_init_f() and board_init_r() to return Simon Glass
2011-09-18 0:05 ` Mike Frysinger
2011-09-23 15:55 ` Simon Glass
2011-09-25 19:55 ` Wolfgang Denk
2011-09-25 20:20 ` Simon Glass
2011-09-26 4:47 ` Mike Frysinger
2011-09-26 16:48 ` Simon Glass
2011-09-26 17:49 ` Anton Staaf
2011-09-26 19:22 ` Simon Glass
2011-09-26 19:25 ` Anton Staaf
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 07/20] sandbox: Add sandbox board Simon Glass
2011-09-18 0:17 ` Mike Frysinger
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 08/20] sandbox: Add board info for architecture Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 09/20] sandbox: Add bootm support Simon Glass
2011-09-18 0:16 ` Mike Frysinger
2011-09-23 15:55 ` Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 10/20] sandbox: Disable built-in malloc Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 11/20] sandbox: Disable standalone/API support Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 12/20] sandbox: Force command sections to be 4-byte aligned Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 13/20] sandbox: Add OS dependent layer Simon Glass
2011-09-18 0:20 ` Mike Frysinger
2011-09-23 15:59 ` Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 14/20] sandbox: Add board_init() Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 15/20] sandbox: Add main program Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 16/20] sandbox: Add serial uart Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 17/20] sandbox: Add basic config file Simon Glass
2011-09-18 0:22 ` Mike Frysinger
2011-09-23 16:00 ` Simon Glass
2011-09-26 4:52 ` Mike Frysinger
2011-09-26 18:18 ` Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 18/20] sandbox: Remove unused variable warnings Simon Glass
2011-09-18 0:25 ` Mike Frysinger
2011-09-23 16:01 ` Simon Glass
2011-09-26 4:49 ` Mike Frysinger [this message]
2011-09-26 18:07 ` Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 19/20] sandbox: Use uintptr_t for 32/64-bit compatibility Simon Glass
2011-09-17 16:48 ` [U-Boot] [RFC PATCH 20/20] sandbox: Makefile changes to build sandbox architecture Simon Glass
2011-09-17 23:54 ` [U-Boot] [RFC PATCH 01/20] sandbox: Add architecture header files Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109260050.00767.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox