From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c
Date: Mon, 26 Sep 2011 11:03:46 +0200 [thread overview]
Message-ID: <201109261103.46320.marek.vasut@gmail.com> (raw)
In-Reply-To: <20110926072536.27B441407998@gemini.denx.de>
On Monday, September 26, 2011 09:25:36 AM Wolfgang Denk wrote:
> Dear Mike Frysinger,
>
> In message <201109252341.30328.vapier@gentoo.org> you wrote:
> > > The assigned variable can be removed because the pointers are volatile
> > > so accesses to their addresses are always generated.
> >
> > i think the stores to a var were added to avoid a gcc warning, but if
> > newer versions don't warn anymore, should be fine.
>
> Obviously we have to check if older tools still accept this.
>
Hi,
as I was never completely sure about this file from the begining, I'm all for
it.
Btw. who's supposed to merge the rest of the series anyway ?
>
> Marek, which tool chains did you use for testing?
Hand-built gcc4.6.0+debian patches and gcc4.4.6+debian patches:
arm-linux-gnueabi-gcc-4.4 (Debian 4.4.6-7) 4.4.6
arm-linux-gnueabi-gcc-4.6 (Debian 4.6.0-14) 4.6.1 20110616 (prerelease)
There was someone on the irc who (unsuccessfully) tried to compile uboot with
gcc 2.xx recently. Maybe we should impose some lower bound for compiler version,
though I guess 4.4 is too high. Suggestions ?
Cheers
>
> Best regards,
>
> Wolfgang Denk
next prev parent reply other threads:[~2011-09-26 9:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 0:26 [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Marek Vasut
2011-09-26 0:26 ` [U-Boot] [PATCH 2/7 RESEND] GCC4.6: Remove unused "port" variable in cmd_usb.c Marek Vasut
2011-09-26 3:40 ` Mike Frysinger
2011-09-26 0:26 ` [U-Boot] [PATCH 3/7] GCC4.6: Squash warning in cmd_flash.c Marek Vasut
2011-10-01 21:25 ` Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 4/7] GCC4.6: Squash warning in cmd_nvedit.c Marek Vasut
2011-09-26 3:39 ` Mike Frysinger
2011-09-26 3:40 ` Mike Frysinger
2011-09-26 18:15 ` Simon Glass
2011-10-01 21:26 ` Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 5/7] GCC4.6: Squash warnings in lcd.c Marek Vasut
2011-10-01 21:26 ` Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 6/7] GCC4.6: Squash warnings in ipu_disp.c Marek Vasut
2011-10-01 21:27 ` Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c Marek Vasut
2011-09-26 3:41 ` Mike Frysinger
2011-09-26 7:25 ` Wolfgang Denk
2011-09-26 9:03 ` Marek Vasut [this message]
2011-09-26 16:10 ` Mike Frysinger
2011-09-26 17:31 ` Marek Vasut
2011-09-26 18:03 ` Wolfgang Denk
2011-09-26 18:29 ` Marek Vasut
2011-09-26 18:49 ` Wolfgang Denk
2011-09-26 19:52 ` Mike Frysinger
2011-09-26 18:05 ` Simon Glass
2011-09-26 18:24 ` Marek Vasut
2011-09-26 18:29 ` Simon Glass
2011-09-26 18:34 ` Marek Vasut
2011-09-26 19:01 ` Simon Glass
2011-09-26 19:10 ` Marek Vasut
2011-09-26 19:13 ` Simon Glass
2011-10-01 21:27 ` Wolfgang Denk
2011-09-26 2:39 ` [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Fabio Estevam
2011-09-26 9:04 ` Marek Vasut
2011-09-26 11:28 ` Wolfgang Denk
2011-09-26 3:41 ` Mike Frysinger
2011-09-26 17:36 ` [U-Boot] [PATCH 1/7 V3] " Marek Vasut
2011-10-01 21:20 ` Wolfgang Denk
2011-10-02 18:36 ` Wolfgang Denk
2011-10-02 19:08 ` Marek Vasut
2011-10-02 22:50 ` Marek Vasut
2011-10-03 18:32 ` [U-Boot] [PATCH 1/7 V2] " Marek Vasut
2011-10-03 18:36 ` Wolfgang Denk
2011-10-03 18:42 ` Marek Vasut
2011-10-03 22:58 ` Marek Vasut
2011-10-04 12:18 ` Marek Vasut
2011-10-04 19:06 ` Marek Vasut
2011-10-04 19:23 ` Wolfgang Denk
2011-10-04 19:46 ` Mike Frysinger
2011-10-04 20:44 ` Wolfgang Denk
2011-10-04 20:58 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109261103.46320.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox