From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Mon, 26 Sep 2011 12:10:37 -0400 Subject: [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c In-Reply-To: <201109261103.46320.marek.vasut@gmail.com> References: <1316996766-14248-1-git-send-email-marek.vasut@gmail.com> <20110926072536.27B441407998@gemini.denx.de> <201109261103.46320.marek.vasut@gmail.com> Message-ID: <201109261210.38017.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, September 26, 2011 05:03:46 Marek Vasut wrote: > On Monday, September 26, 2011 09:25:36 AM Wolfgang Denk wrote: > > Mike Frysinger wrote: > > > > The assigned variable can be removed because the pointers are > > > > volatile so accesses to their addresses are always generated. > > > > > > i think the stores to a var were added to avoid a gcc warning, but if > > > newer versions don't warn anymore, should be fine. > > > > Obviously we have to check if older tools still accept this. > > Hi, > > as I was never completely sure about this file from the begining, I'm all > for it. > > Btw. who's supposed to merge the rest of the series anyway ? > > > Marek, which tool chains did you use for testing? > > Hand-built gcc4.6.0+debian patches and gcc4.4.6+debian patches: > > arm-linux-gnueabi-gcc-4.4 (Debian 4.4.6-7) 4.4.6 > arm-linux-gnueabi-gcc-4.6 (Debian 4.6.0-14) 4.6.1 20110616 (prerelease) > > There was someone on the irc who (unsuccessfully) tried to compile uboot > with gcc 2.xx recently. Maybe we should impose some lower bound for > compiler version, though I guess 4.4 is too high. Suggestions ? i think gcc-3.x has been broken for a while but no one has noticed -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20110926/9b986100/attachment.pgp