public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] image: push default arch values to arch headers
Date: Mon, 26 Sep 2011 14:15:13 -0400	[thread overview]
Message-ID: <201109261415.14398.vapier@gentoo.org> (raw)
In-Reply-To: <20110926175859.51C34140799A@gemini.denx.de>

On Monday, September 26, 2011 13:58:59 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > ...here you change a compile time error check into a runtim error.
> > 
> > no, it'll still be a build time error as IH_ARCH_DEFAULT will be
> > undefined
> > 
> > it just might not be as clean an error ... gcc will complain about
> > IH_ARCH_DEFAULT not being defined rather than a helpful "Unknown CPU
> > type"
> 
> Should it not be trivial to add a
> 
> 	#ifndef IH_ARCH_DEFAULT
> 	# error Unknown CPU type: IH_ARCH_DEFAULT not set
> 	#endif
> 
> or similar to include/image.h ?

it'd certainly be easy to do.  i just pointed out that you still get a build 
failure after my change :).  so if you want the #error, i'll resend w/it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110926/9a1f3d90/attachment.pgp 

  reply	other threads:[~2011-09-26 18:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26  5:53 [U-Boot] [PATCH] image: push default arch values to arch headers Mike Frysinger
2011-09-26  6:08 ` Wolfgang Denk
2011-09-26 16:09   ` Mike Frysinger
2011-09-26 17:58     ` Wolfgang Denk
2011-09-26 18:15       ` Mike Frysinger [this message]
2011-09-26 18:45         ` Wolfgang Denk
2011-09-26 19:58 ` [U-Boot] [PATCH v2] " Mike Frysinger
2011-09-29  6:18   ` Thomas Chou
2011-10-04  0:50 ` [U-Boot] [PATCH v3] " Mike Frysinger
2011-10-05 18:58   ` Wolfgang Denk
     [not found] ` <1317016410-608-2-git-send-email-vapier@gentoo.org>
2011-10-05 18:57   ` [U-Boot] [PATCH] MAKEALL: rename coldfire list to m68k to match arch Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201109261415.14398.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox