[U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c

Marek Vasut
2011-09-26T09:03:46Z

On Monday, September 26, 2011 09:25:36 AM Wolfgang Denk wrote:
> Dear Mike Frysinger,
>
> In message <201109252341.30328.vapier@gentoo.org> you wrote:
> > > The assigned variable can be removed because the pointers are volatile
> > > so accesses to their addresses are always generated.
> >
> > i think the stores to a var were added to avoid a gcc warning, but if
> > newer versions don't warn anymore, should be fine.
>
> Obviously we have to check if older tools still accept this.
>

Hi,

as I was never completely sure about this file from the begining, I'm all for
it.

Btw. who's supposed to merge the rest of the series anyway ?

>
> Marek, which tool chains did you use for testing?

Hand-built gcc4.6.0+debian patches and gcc4.4.6+debian patches:

arm-linux-gnueabi-gcc-4.4 (Debian 4.4.6-7) 4.4.6
arm-linux-gnueabi-gcc-4.6 (Debian 4.6.0-14) 4.6.1 20110616 (prerelease)

There was someone on the irc who (unsuccessfully) tried to compile uboot with
gcc 2.xx recently. Maybe we should impose some lower bound for compiler version,
though I guess 4.4 is too high. Suggestions ?

Cheers
>
> Best regards,
>
> Wolfgang Denk