[U-Boot] [PATCH 1/7 V3] GCC4.6: Convert various empty macros to inline functions

Wolfgang Denk
2011-10-02T18:36:04Z

Dear Marik,

In message <1317058579-936-1-git-send-email-marek.vasut@gmail.com> you wrote:
> Fix the following gcc4.6 problems:
>
> cmd_date.c: In function `do_date?:
> cmd_date.c:50:6: warning: variable `old_bus? set but not used
> [-Wunused-but-set-variable]
> asix.c: In function `asix_init?:
> asix.c:317:6: warning: variable `rx_ctl? set but not used
> [-Wunused-but-set-variable]
> usb.c: In function `usb_parse_config?:
> usb.c:331:17: warning: variable `ch? set but not used
> [-Wunused-but-set-variable]
> usb.c: In function `usb_hub_port_connect_change?:
> usb.c:1123:29: warning: variable `portchange? set but not used
> [-Wunused-but-set-variable]
> usb.c: In function `usb_hub_configure?:
> usb.c:1183:25: warning: variable `hubsts? set but not used
> [-Wunused-but-set-variable]
> usb_storage.c: In function `usb_stor_CB_reset?:
> usb_storage.c:466:6: warning: variable `result? set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
> common/usb.c | 4 ++--
> common/usb_storage.c | 2 +-
> include/common.h | 4 ++--
> include/i2c.h | 5 ++++-
> 4 files changed, 9 insertions(+), 6 deletions(-)

Unforstunately this patch breaks a number of boards.

Did you by chance forget to run MAKEALL on it? :-(

Example:

./MAKEALL TQM823L
Configuring for TQM823L board...
tqm8xx_pcmcia.c: In function 'pcmcia_voltage_set':
tqm8xx_pcmcia.c:265: error: 'pcmp' undeclared (first use in this function)
tqm8xx_pcmcia.c:265: error: (Each undeclared identifier is reported only once
tqm8xx_pcmcia.c:265: error: for each function it appears in.)
make[1]: *** [/work/wd/tmp-ppc/drivers/pcmcia/tqm8xx_pcmcia.o] Error 1
make: *** [/work/wd/tmp-ppc/drivers/pcmcia/libpcmcia.o] Error 2
make: *** Waiting for unfinished jobs....
ppc_6xx-size: '/work/wd/tmp-ppc/u-boot': No such file

...
60ce53cf9f408d9ad721f8e7a87d6a564e6d5bac is the first bad commit
commit 60ce53cf9f408d9ad721f8e7a87d6a564e6d5bac
Author: Marek Vasut <marek.vasut@gmail.com>
Date: Mon Sep 26 19:36:19 2011 +0200

GCC4.6: Convert various empty macros to inline functions

Please fix.

Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The word "fit", as I understand it, means "appropriate to a purpose",
and I would say the body of the Dean is supremely appropriate to the
purpose of sitting around all day and eating big heavy meals.
- Terry Pratchett, _Moving Pictures_