From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Tue, 27 Sep 2011 16:55:54 +0200
Subject: [U-Boot] [PATCH v5 4/4] Add USB support for Efika
In-Reply-To: <CAB+7RbHnLzuP7=N0fTzUvUSjU0q1otv45u0giAi14y3NDLSrVQ@mail.gmail.com>
References: <1317120333-17275-1-git-send-email-fermata7@gmail.com>
	<201109271350.53459.marek.vasut@gmail.com>
	<CAB+7RbHnLzuP7=N0fTzUvUSjU0q1otv45u0giAi14y3NDLSrVQ@mail.gmail.com>
Message-ID: <201109271655.54798.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday, September 27, 2011 04:12:18 PM Jana Rapava wrote:
> 2011/9/27 Marek Vasut <marek.vasut@gmail.com>
> 
> > >  /*
> > > 
> > > + * EHCI USB
> > > + */
> > > +#ifdef       CONFIG_CMD_USB
> > > +void setup_iomux_usb(void);
> > > +#else
> > > +static inline void setup_iomux_usb(void) { }
> > > +#endif
> > > +
> > 
> > Can you introduce efika.h header and move this to the header please.
> 
> Should I move all #define's and #ifdef's, or only this?

The defines are local, move only this
> 
> Regards,
> Jana Rapava