From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/5 V2] NAND: Make page, erase, oob size available via cmd_nand
Date: Tue, 27 Sep 2011 21:38:59 +0200 [thread overview]
Message-ID: <201109272138.59945.marek.vasut@gmail.com> (raw)
In-Reply-To: <20110927190153.GC10082@schlenkerla.am.freescale.net>
On Tuesday, September 27, 2011 09:01:53 PM Scott Wood wrote:
> On Thu, Sep 22, 2011 at 03:57:26AM +0200, Marek Vasut wrote:
> > diff --git a/common/cmd_nand.c b/common/cmd_nand.c
> > index 72d418c..2f8723f 100644
> > --- a/common/cmd_nand.c
> > +++ b/common/cmd_nand.c
> >
> > @@ -362,15 +362,34 @@ usage:
> > #endif
> >
> > -static void nand_print_info(int idx)
> > +static void nand_print_and_set_info(int idx)
> >
> > {
> >
> > nand_info_t *nand = &nand_info[idx];
> > struct nand_chip *chip = nand->priv;
> >
> > + const int bufsz = 32;
> > + char buf[bufsz];
> > +
> >
> > printf("Device %d: ", idx);
> > if (chip->numchips > 1)
> >
> > printf("%dx ", chip->numchips);
> >
> > printf("%s, sector size %u KiB\n",
> >
> > nand->name, nand->erasesize >> 10);
> >
> > + printf(" Page size %8d b\n", nand->writesize);
> > + printf(" OOB size %8d b\n", nand->oobsize);
> > + printf(" Erase size %8d b\n", nand->erasesize);
> > +
> > + /* Set geometry info */
> > + memset(buf, 0, bufsz);
> > + sprintf(buf, "%x", nand->writesize);
> > + setenv("nand_writesize", buf);
> > +
> > + memset(buf, 0, bufsz);
> > + sprintf(buf, "%x", nand->oobsize);
> > + setenv("nand_oobsize", buf);
> > +
> > + memset(buf, 0, bufsz);
> > + sprintf(buf, "%x", nand->erasesize);
> > + setenv("nand_erasesize", buf);
>
> Why the memsets?
To clear the memory from previous usage ?
>
> -Scott
next prev parent reply other threads:[~2011-09-27 19:38 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 4:04 [U-Boot] [PATCH 0/5 V2] Random NAND fixes and improvements Marek Vasut
2011-09-12 4:04 ` [U-Boot] [PATCH 1/5] NAND: Really ignore bad blocks when scrubbing Marek Vasut
2011-09-27 18:54 ` Scott Wood
2011-09-12 4:04 ` [U-Boot] [PATCH 2/5] NAND: Add nand read.raw and write.raw commands Marek Vasut
2011-09-21 18:48 ` Scott Wood
2011-09-22 1:55 ` [U-Boot] [PATCH 2/5 V2] " Marek Vasut
2011-09-22 16:03 ` Scott Wood
2011-09-22 18:36 ` [U-Boot] [PATCH 2/5 V3] " Marek Vasut
2011-09-22 18:40 ` Scott Wood
2011-09-23 13:43 ` [U-Boot] [PATCH 2/5 V4] " Marek Vasut
2011-09-27 18:57 ` Scott Wood
2011-09-12 4:04 ` [U-Boot] [PATCH 3/5] NAND: Allow per-buffer allocation Marek Vasut
2011-09-21 18:50 ` Scott Wood
2011-09-21 19:49 ` Wolfgang Denk
2011-09-21 19:55 ` Scott Wood
2011-09-21 20:16 ` Wolfgang Denk
2011-09-22 1:34 ` Marek Vasut
2011-09-22 7:41 ` Stefano Babic
2011-09-22 8:51 ` Marek Vasut
2011-09-23 17:35 ` Scott Wood
2011-09-24 12:37 ` Marek Vasut
2011-09-26 18:33 ` Scott Wood
2011-09-26 18:49 ` Marek Vasut
2011-09-12 4:04 ` [U-Boot] [PATCH 4/5] NAND: Make page, erase, oob size available via cmd_nand Marek Vasut
2011-09-21 18:55 ` Scott Wood
2011-09-21 19:52 ` Wolfgang Denk
2011-09-22 1:57 ` [U-Boot] [PATCH 4/5 V2] " Marek Vasut
2011-09-27 19:01 ` Scott Wood
2011-09-27 19:38 ` Marek Vasut [this message]
2011-09-27 19:51 ` Scott Wood
2011-09-27 20:07 ` Marek Vasut
2011-09-27 20:53 ` Scott Wood
2011-09-27 21:04 ` Marek Vasut
2011-09-27 21:14 ` Scott Wood
2011-09-12 4:04 ` [U-Boot] [PATCH 5/5] NAND: Add scrub.quiet command option Marek Vasut
2011-09-12 16:45 ` Mike Frysinger
2011-09-12 17:45 ` Marek Vasut
2011-09-12 18:06 ` Scott Wood
2011-09-12 18:24 ` Marek Vasut
2011-09-12 18:31 ` Scott Wood
2011-09-12 18:36 ` Marek Vasut
2011-09-12 19:19 ` Scott Wood
2011-09-12 19:28 ` Marek Vasut
2011-09-12 19:36 ` Scott Wood
2011-09-12 19:42 ` Marek Vasut
2011-09-12 23:24 ` Scott Wood
2011-09-13 1:02 ` Marek Vasut
2011-09-13 4:25 ` Wolfgang Denk
2011-09-13 4:36 ` Marek Vasut
2011-09-13 22:22 ` Scott Wood
2011-09-13 22:41 ` Marek Vasut
2011-09-13 22:53 ` Scott Wood
2011-09-12 18:37 ` Wolfgang Denk
2011-09-12 18:50 ` Marek Vasut
2011-09-12 20:33 ` Mike Frysinger
2011-09-12 22:59 ` Marek Vasut
2011-09-13 22:20 ` [U-Boot] [PATCH 5/5] NAND: Add -y option to nand scrub command Marek Vasut
2011-09-13 22:28 ` Mike Frysinger
2011-09-27 19:03 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109272138.59945.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox