From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 28 Sep 2011 14:28:21 +0200
Subject: [U-Boot] [PATCH v7 4/4] Add USB support for Efika
In-Reply-To: <CAB+7RbF518RnzJbKBpMn4W0Ck5_DhGVe-Mk75i=X_Vk3KFUtyg@mail.gmail.com>
References: <1317151457-15387-1-git-send-email-fermata7@gmail.com>
	<1317170582.3390.2.camel@konomi>
	<CAB+7RbF518RnzJbKBpMn4W0Ck5_DhGVe-Mk75i=X_Vk3KFUtyg@mail.gmail.com>
Message-ID: <201109281428.21487.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, September 28, 2011 02:25:14 PM Jana Rapava wrote:
> 2011/9/28 Marek Vasut <marek.vasut.n900@gmail.com>
> 
> > > +    /* get ID from ULPI immediate registers */
> > > +    for (reg = ULPI_ID_REGS_COUNT - 1; reg >= 0; reg--)
> > > +        tmp |= ulpi_read(ehci, (u32)reg) << (reg * 8);
> > 
> > Are you ignoring my comment and picking only some of them? Is the cast
> > here necessary?
> 
> Sorry, I try to change patches according to your requests, but sometimes I
> overlook something.
> Also, it looks like I forgot to add proper header to efikamx-usb.c. Should
> I add it in the next version?

yes ... 

Copyright (C) 2011 Marek Vasut <marek.vasut@gmail.com>
Copyright (C) 2011 Jana Rapava <fermata7@gmail.com>

> 
> > > +    /* USB 2.0 specification say 50 ms resets on root. */
> > 
> > Where can I read about this please?
> 
> Universal Serial Bus Specification Revision 2.0, chapter 7.1.7.5 Reset
> Signaling says: "It is required that resets from root ports have a duration
> of at least 50 ms (TDRSTR)."

OK

> 
> Regards,
> Jana Rapava