From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Thu, 29 Sep 2011 00:12:23 +0200
Subject: [U-Boot] [PATCH 09/15] iMX28: Add GPMI NAND driver
In-Reply-To: <4E839115.6000409@freescale.com>
References: <1315800409-19876-1-git-send-email-marek.vasut@gmail.com>
	<1315800409-19876-10-git-send-email-marek.vasut@gmail.com>
	<4E839115.6000409@freescale.com>
Message-ID: <201109290012.23189.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, September 28, 2011 11:26:45 PM Scott Wood wrote:
> On 09/11/2011 11:06 PM, Marek Vasut wrote:
> > +static void mxs_nand_return_dma_descs(struct mxs_nand_info *info)
> > +{
> > +	int i = info->desc_index;
> > +	struct mxs_dma_desc *desc;
> > +
> > +	for (--i; i >= 0; i--) {
> 
> This is an awkward construct.
> 
> Why not just the usual:
> 
> for (i = 0; i < info->desc_index; i++)
> 

Checking the driver, this modifies the global data so this is ok